Skip to content

Fix #501: add --with-lto to 3.10 and newer #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

blopker
Copy link
Contributor

@blopker blopker commented Oct 19, 2021

This PR is to add --with-lto to Python images 3.10 and newer as those Pythons are now configured with -fno-semantic-interposition upstream. This is a performance enhancement.

@johnthagen
Copy link

@blopker This is great. Would it be worth adding a comment somewhere that --with-lto increases performance by up to 30%? I could see someone in the future being tempted to remove --with-lto to improve build times, not realizing the history that this is now a very important performance flag.

Since this flag is replicated across a bunch of Dockerfiles, I'm not sure where the best place for this is (maybe expanding the comment in update.sh?)

Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane IMO -- I think the note in update.sh is enough for now. 👍

Thank you!

@tianon tianon merged commit 70b2802 into docker-library:master Oct 19, 2021
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Oct 19, 2021
Changes:

- docker-library/python@70b2802: Merge pull request docker-library/python#660 from blopker/feature/with-lto
- docker-library/python@1fa00a0: Fix docker-library/python#501: add --with-lto to 3.10 and newer
- docker-library/python@35fa20f: Update to 3.8.12, setuptools 57.5.0, pip 21.2.4
- docker-library/python@5665256: Update to 3.6.15, setuptools 57.5.0, pip 21.2.4
- docker-library/python@b6b534f: Update to 3.7.12, setuptools 57.5.0, pip 21.2.4
- docker-library/python@62ec6a1: Update to 3.11.0a1, setuptools 57.5.0, pip 21.2.4
- docker-library/python@1c48a50: Update to 3.9.7, setuptools 57.5.0, pip 21.2.4
- docker-library/python@652ed14: Update to 3.10.0, setuptools 57.5.0, pip 21.2.4
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Oct 23, 2021
Changes:

- docker-library/python@9242c44: Update to 3.8.12, setuptools 57.5.0, pip 21.2.4
- docker-library/python@59a27ea: Update to 3.6.15, setuptools 57.5.0, pip 21.2.4
- docker-library/python@a765583: Update to 3.7.12, setuptools 57.5.0, pip 21.2.4
- docker-library/python@1f16f24: Update to 3.11.0a1, setuptools 57.5.0, pip 21.2.4
- docker-library/python@a7ff0b7: Update to 3.9.7, setuptools 57.5.0, pip 21.2.4
- docker-library/python@8e59156: Update to 3.10.0, setuptools 57.5.0, pip 21.2.4
- docker-library/python@70b2802: Merge pull request docker-library/python#660 from blopker/feature/with-lto
- docker-library/python@1fa00a0: Fix docker-library/python#501: add --with-lto to 3.10 and newer
- docker-library/python@35fa20f: Update to 3.8.12, setuptools 57.5.0, pip 21.2.4
- docker-library/python@5665256: Update to 3.6.15, setuptools 57.5.0, pip 21.2.4
- docker-library/python@b6b534f: Update to 3.7.12, setuptools 57.5.0, pip 21.2.4
- docker-library/python@62ec6a1: Update to 3.11.0a1, setuptools 57.5.0, pip 21.2.4
- docker-library/python@1c48a50: Update to 3.9.7, setuptools 57.5.0, pip 21.2.4
- docker-library/python@652ed14: Update to 3.10.0, setuptools 57.5.0, pip 21.2.4
NeilHanlon pushed a commit to NeilHanlon/official-images that referenced this pull request Oct 27, 2021
Changes:

- docker-library/python@9242c44: Update to 3.8.12, setuptools 57.5.0, pip 21.2.4
- docker-library/python@59a27ea: Update to 3.6.15, setuptools 57.5.0, pip 21.2.4
- docker-library/python@a765583: Update to 3.7.12, setuptools 57.5.0, pip 21.2.4
- docker-library/python@1f16f24: Update to 3.11.0a1, setuptools 57.5.0, pip 21.2.4
- docker-library/python@a7ff0b7: Update to 3.9.7, setuptools 57.5.0, pip 21.2.4
- docker-library/python@8e59156: Update to 3.10.0, setuptools 57.5.0, pip 21.2.4
- docker-library/python@70b2802: Merge pull request docker-library/python#660 from blopker/feature/with-lto
- docker-library/python@1fa00a0: Fix docker-library/python#501: add --with-lto to 3.10 and newer
- docker-library/python@35fa20f: Update to 3.8.12, setuptools 57.5.0, pip 21.2.4
- docker-library/python@5665256: Update to 3.6.15, setuptools 57.5.0, pip 21.2.4
- docker-library/python@b6b534f: Update to 3.7.12, setuptools 57.5.0, pip 21.2.4
- docker-library/python@62ec6a1: Update to 3.11.0a1, setuptools 57.5.0, pip 21.2.4
- docker-library/python@1c48a50: Update to 3.9.7, setuptools 57.5.0, pip 21.2.4
- docker-library/python@652ed14: Update to 3.10.0, setuptools 57.5.0, pip 21.2.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants