Skip to content

Add "buster" variants #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

dentarg
Copy link

@dentarg dentarg commented Jul 31, 2018

For the slim variants, I had to remove libgdbm3, https://packages.debian.org/buster/libgdbm3 says

Package not available in this suite.

(I don't know what libgdbm3 is used for, git log -S tells me it was added in #33)

Otherwise, I just changed stretch to buster.

I have built the images and tested ruby -v in each of them.

Related to #224

@dentarg
Copy link
Author

dentarg commented Jul 31, 2018

Ah, the removal of libgdbm3 is what is causing the tests to fail, and the tests are in the official-images repo

I will see if I can figure it out (no promises though)

@dentarg
Copy link
Author

dentarg commented Jul 31, 2018

Ah, we probably want https://packages.debian.org/buster/libgdbm5

@dentarg
Copy link
Author

dentarg commented Jul 31, 2018

Ah, we probably want https://packages.debian.org/buster/libgdbm5

Only solved one of two

$ docker run --rm -it 2.6-rc-slim-buster ruby -e 'require "gdbm"'

$ docker run --rm -it 2.6-rc-slim-buster ruby -e 'require "dbm"'
Traceback (most recent call last):
	2: from -e:1:in `<main>'
	1: from /usr/local/lib/ruby/site_ruby/2.6.0/rubygems/core_ext/kernel_require.rb:59:in `require'
/usr/local/lib/ruby/site_ruby/2.6.0/rubygems/core_ext/kernel_require.rb:59:in `require': cannot load such file -- dbm (LoadError)

@dentarg
Copy link
Author

dentarg commented Jul 31, 2018

From the docker build log

*** Following extensions are not compiled:
dbm:
	Could not be configured. It will not be installed.
	Check ext/dbm/mkmf.log for more details.
*** Fix the problems, then remove these directories and try again if you want.

@dentarg
Copy link
Author

dentarg commented Jul 31, 2018

For the slim versions, libgdbm3 had to be replaced with libgdbm5 and
libgdbm-compat-dev.
bison \
dpkg-dev \
libgdbm-dev \
# ruby 2.3 on stretch can only support libssl1.0-dev (libssl dev from buildpack-deps is 1.1.x)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment probably needs some updating ("buster" instead of "stretch" and maybe more)

@dentarg
Copy link
Author

dentarg commented Jul 31, 2018

The test failure is unrelated (the VERSION=2.6-rc VARIANT=alpine3.7 build timed out), but I will close this PR as there will be some time before buster variants will be considered (see #224 (comment)).

@dentarg dentarg closed this Jul 31, 2018
@dentarg dentarg mentioned this pull request Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant