Remove ENABLE_PATH_CHECK workaround
#490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Since Ruby 2.7, this warning is not emitted anymore It was removed as part of https://bugs.ruby-lang.org/issues/16131 Here's the output of running `ENV['PATH']` against various ruby versions, when `$PATH` contains a world-writable folder: ``` ===============1.8.7-p374================ -e:1: warning: Insecure world writable dir /app/whatever in PATH, mode 040757 ===============1.9.3-p551================ -e:1: warning: Insecure world writable dir /app/whatever in PATH, mode 040757 ===============2.0.0-p648================ -e:1: warning: Insecure world writable dir /app/whatever in PATH, mode 040757 =================2.1.10================== -e:1: warning: Insecure world writable dir /app/whatever in PATH, mode 040757 =================2.2.10================== -e:1: warning: Insecure world writable dir /app/whatever in PATH, mode 040757 ==================2.3.8================== -e:1: warning: Insecure world writable dir /app/whatever in PATH, mode 040757 =================2.4.10================== -e:1: warning: Insecure world writable dir /app/whatever in PATH, mode 040757 ==================2.5.9================== -e:1: warning: Insecure world writable dir /app/whatever in PATH, mode 040757 =================2.6.10================== -e:1: warning: Insecure world writable dir /app/whatever in PATH, mode 040757 ==================2.7.8================== ==================3.0.7================== ==================3.1.6================== ==================3.2.6================== ==================3.3.6================== ================3.4.0-rc1================ ``` In https://bugs.ruby-lang.org/issues/20971, it was OKed to officially deprecate since not emitting this was unintentional at the time
Earlopain
force-pushed
the
remove-path-check-workaround
branch
from
4be7bd8 to
c12fe5b
Compare
Contributor
Author
|
This is ready now. It was decided in the last developer meeting that omitting this warning is now intentional, even if it was by accident initially (see issue linked above) |
tianon
approved these changes
Feb 14, 2025
Member
tianon
left a comment
tianon
left a comment
There was a problem hiding this comment.
Nice, thanks for pushing this! Hopefully ruby/ruby#12542 gets merged (soon?), but I've verified it's unused and https://bugs.ruby-lang.org/issues/20971#note-12 does seem pretty conclusive. 😄
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Feb 15, 2025
Changes: - docker-library/ruby@b8c4907: Update 3.4 to 3.4.2 - docker-library/ruby@02bc038: Merge pull request docker-library/ruby#490 from Earlopain/remove-path-check-workaround - docker-library/ruby@c12fe5b: Remove `ENABLE_PATH_CHECK` workaround
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Ruby 2.7, this warning is not emitted anymore It was removed as part of https://bugs.ruby-lang.org/issues/16131
Here's the output of running
ENV['PATH']against various ruby versions, when$PATHcontains a world-writable folder: