dap: utilize the dap.hint.noparent from LLB if it exists
#3348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
force-pushed
the
dap-hint-noparent
branch
from
83806de to
d3185f8
Compare
crazy-max
reviewed
Aug 4, 2025
dap/thread.go
Outdated
|
|
||
| hasParent := len(op.Inputs) > 0 | ||
| if m, ok := t.def.Metadata[first.dgst]; ok { | ||
| if s, ok := m.Description["com.docker.dap.hint.v1.noparent"]; ok { |
There was a problem hiding this comment.
Was wondering if we could use a fallback frontend image like we have done for build checks and outline requests so everyone can benefit from this feature but would need first a frontend capability I suppose which I don't think is necessary.
This annotation signals that the LLB node doesn't have a direct parent and the inputs are disconnected. This prevents us from accidentally including them in the same stack frame. Signed-off-by: Jonathan A. Sternberg <[email protected]>
jsternberg
force-pushed
the
dap-hint-noparent
branch
from
d3185f8 to
12b2204
Compare
|
Not needed anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This annotation signals that the LLB node doesn't have a direct parent
and the inputs are disconnected. This prevents us from accidentally
including them in the same stack frame.
Requires moby/buildkit#6117.