Skip to content

Conversation

AkihiroSuda
Copy link
Collaborator

The install/uninstall commands were introduced in #34 (Apr 2019) as hidden commands.

These commands should no longer be hidden, as they have been explicitly documented since docker/docs#21641 (Dec 2024).

https://docs.docker.com/build/builders/#difference-between-docker-build-and-docker-buildx-build

@crazy-max
Copy link
Member

These commands should no longer be hidden

I think we want to keep them hidden since docker build is an alias of docker buildx build and docker builder an alias of docker buildx and therefore install/uninstall does not have any effect anymore, see docker/cli#3314. As there are hidden commands, we also explicitly removed the documentation in #1918.

We should remove them in the future imo but first deprecate them. Same in our GHA https://github.com/docker/setup-buildx-action/blob/1583c0f09d26c58c59d25b0eef29792b7ce99d9a/action.yml#L29-L32. WDYT @tonistiigi @colinhemmings?

@AkihiroSuda
Copy link
Collaborator Author

I think we want to keep them hidden since docker build is an alias of docker buildx build and docker builder an alias of docker buildx and therefore install/uninstall does not have any effect anymore, see docker/cli#3314.

Seems to still have an effect.
The difference is that docker buildx install makes docker build respect the builder specified via docker buildx use.

https://github.com/docker/docs/blob/3d174fdbea6765c86344beab0f90067f640c937b/content/manuals/build/builders/_index.md?plain=1#L68-L108

The install/uninstall commands were introduced in
PR 34 (Apr 2019) as hidden commands.

These commands should no longer be hidden,
as they have been explicitly documented since
docker/docs PR 21641 (Dec 2024).

https://docs.docker.com/build/builders/#difference-between-docker-build-and-docker-buildx-build

Signed-off-by: Akihiro Suda <[email protected]>
@crazy-max
Copy link
Member

I think we want to keep them hidden since docker build is an alias of docker buildx build and docker builder an alias of docker buildx and therefore install/uninstall does not have any effect anymore, see docker/cli#3314.

Seems to still have an effect. The difference is that docker buildx install makes docker build respect the builder specified via docker buildx use.

https://github.com/docker/docs/blob/3d174fdbea6765c86344beab0f90067f640c937b/content/manuals/build/builders/_index.md?plain=1#L68-L108

Ah indeed forgot about this case: docker/cli#3676 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants