policy: enable proxy network from source policy caps#3895
Merged
Conversation
Evaluate source policy caps before solve requests so policies can enable
BuildKit proxy networking. Policy can return caps {"exec.proxy": true}
during the caps request to enable proxy network
support for the solve.
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
crazy-max
force-pushed
the
exec-proxy-support
branch
from
June 10, 2026 13:04
8cd1c2a to
e08f0fc
Compare
crazy-max
reviewed
Jun 10, 2026
| if err := applyPolicyCaps(ctx, p, bopts, so); err != nil { | ||
| return nil, err | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
I think it could poitentially reject existing policies that never request caps?
Maybe we can treat an undefined or empty decision during caps probing as empty caps?
Member
Author
There was a problem hiding this comment.
If the policies do not define caps then it is as good as having caps false. If one policy requires caps and others don't (explicitly or not) then caps still needed.
Comment on lines
+65
to
+73
| server := httpserver.NewTestServer(map[string]*httpserver.Response{ | ||
| "/file": resp, | ||
| }) | ||
| defer server.Close() | ||
|
|
||
| dockerfile := []byte(` | ||
| FROM busybox:latest | ||
| RUN wget -O- ` + server.URL + `/file | ||
| `) |
Member
There was a problem hiding this comment.
seems to run through the normal build path because server.URL is a loopback/local endpoint. With the new proxy behavior local services are only reachable in the host+proxy case iiuc
not sure if we can have a proxy-reachable non-loopback test endpoint
Member
Author
There was a problem hiding this comment.
This always fails anyway, but test checks that it fails with "policy deny".
Extend testBuildPolicyCapsProxy so that instead of only checking that the network proxy was enabled, the build runs a command that makes an HTTP request to a local test server. The policy denies that URL as an HTTP source, so the test now verifies that exec traffic actually flows through the proxy and is subject to source policy, including the deny message and DENY decision in the build output. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
exec-proxy-support
branch
from
June 10, 2026 15:59
e08f0fc to
25db0fb
Compare
crazy-max
approved these changes
Jun 10, 2026
eleboucher
pushed a commit
to eleboucher/runner
that referenced
this pull request
Jul 9, 2026
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [buildx](https://github.com/docker/buildx) | | minor | `v0.34.1` → `v0.35.0` | | [buildx](https://github.com/docker/buildx) | uses-with | minor | `v0.34.1` → `v0.35.0` | --- ### Release Notes <details> <summary>docker/buildx (buildx)</summary> ### [`v0.35.0`](https://github.com/docker/buildx/releases/tag/v0.35.0) [Compare Source](docker/buildx@v0.34.1...v0.35.0-rc2) buildx 0.35.0 Welcome to the v0.35.0 release of buildx! Please try out the release binaries and report any issues at <https://github.com/docker/buildx/issues>. ##### Contributors - CrazyMax - Tõnis Tiigi - Sebastiaan van Stijn - Areeb Ahmed - Jiří Moravčík - Sopho Merkviladze - Akihiro Suda - Jonathan A. Sternberg ##### Notable Changes - Local output now supports a `mode=delete` attribute for build and bake commands. This mode replaces the destination directory with the build result instead of merging it. Similar to the `--delete` flag in rsync. For safety, this mode is only allowed if the destination directory is a subdirectory of the working directory. To export to other destinations, `--allow=buildx.local.delete` needs to be provided or the action confirmed by the user in the TUI. When exporting multi-platform results, this mode requires BuildKit v0.31.0+. [#​3883](docker/buildx#3883) - Source policies now support the new exec proxy feature of BuildKit v0.31.0+ that captures the network traffic of your build steps. To opt in to network proxy, your Dockerfile.rego source policy needs to return `caps: { "exec.proxy": true }` in the evaluation decision. After opting in, you can control what network requests are allowed to be made by the run steps with policy rules for regular `input.http` sources, similar to how this was done for direct HTTP build sources before. You can also opt in your whole builder with `--buildkitd-flags '--proxy-network'` in `buildx create`. [#​3895](docker/buildx#3895) - Resource limits can now be set for CPU and memory using the `--resource` flag in `build` and the `resource` key in `bake` commands. This feature requires BuildKit v0.31.0+ and Dockerfile v1.25.0+. [#​3876](docker/buildx#3876) [#​3900](docker/buildx#3900) - Fix possible "closed channel" panic. [#​3886](docker/buildx#3886) ##### Dependency Changes - **github.com/aws/aws-sdk-go-v2** v1.41.7 -> v1.42.0 - **github.com/aws/aws-sdk-go-v2/config** v1.32.17 -> v1.32.24 - **github.com/aws/aws-sdk-go-v2/credentials** v1.19.16 -> v1.19.23 - **github.com/aws/aws-sdk-go-v2/feature/ec2/imds** v1.18.23 -> v1.18.29 - **github.com/aws/aws-sdk-go-v2/internal/configsources** v1.4.23 -> v1.4.29 - **github.com/aws/aws-sdk-go-v2/internal/endpoints/v2** v2.7.23 -> v2.7.29 - **github.com/aws/aws-sdk-go-v2/internal/v4a** v1.4.24 -> v1.4.30 - **github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding** v1.13.9 -> v1.13.12 - **github.com/aws/aws-sdk-go-v2/service/internal/presigned-url** v1.13.23 -> v1.13.29 - **github.com/aws/aws-sdk-go-v2/service/signin** v1.0.11 -> v1.1.5 - **github.com/aws/aws-sdk-go-v2/service/sso** v1.30.17 -> v1.31.3 - **github.com/aws/aws-sdk-go-v2/service/ssooidc** v1.35.21 -> v1.36.6 - **github.com/aws/aws-sdk-go-v2/service/sts** v1.42.1 -> v1.43.3 - **github.com/aws/smithy-go** v1.25.1 -> v1.27.2 - **github.com/containerd/containerd/v2** v2.2.3 -> v2.2.4 - **github.com/containerd/continuity** v0.4.5 -> v0.5.0 - **github.com/containerd/platforms** v1.0.0-rc.2 -> v1.0.0-rc.4 - **github.com/containerd/typeurl/v2** v2.2.3 -> v2.3.0 - **github.com/docker/cli** v29.4.3 -> v29.5.3 - **github.com/docker/distribution** v2.8.3 ***new*** - **github.com/docker/docker-credential-helpers** v0.9.5 -> v0.9.8 - **github.com/go-openapi/analysis** v0.24.3 -> v0.25.2 - **github.com/go-openapi/jsonpointer** v0.22.5 -> v0.23.1 - **github.com/go-openapi/jsonreference** v0.21.5 -> v0.21.6 - **github.com/go-openapi/runtime** v0.29.3 -> v0.32.3 - **github.com/go-openapi/runtime/server-middleware** v0.30.0 ***new*** - **github.com/go-openapi/spec** v0.22.4 -> v0.22.5 - **github.com/go-openapi/strfmt** v0.26.1 -> v0.26.3 - **github.com/go-openapi/swag** v0.25.5 -> v0.26.0 - **github.com/go-openapi/swag/cmdutils** v0.25.5 -> v0.26.0 - **github.com/go-openapi/swag/conv** v0.25.5 -> v0.26.0 - **github.com/go-openapi/swag/fileutils** v0.25.5 -> v0.26.0 - **github.com/go-openapi/swag/jsonname** v0.25.5 -> v0.26.0 - **github.com/go-openapi/swag/jsonutils** v0.25.5 -> v0.26.0 - **github.com/go-openapi/swag/loading** v0.25.5 -> v0.26.0 - **github.com/go-openapi/swag/mangling** v0.25.5 -> v0.26.0 - **github.com/go-openapi/swag/netutils** v0.25.5 -> v0.26.0 - **github.com/go-openapi/swag/stringutils** v0.25.5 -> v0.26.0 - **github.com/go-openapi/swag/typeutils** v0.25.5 -> v0.26.0 - **github.com/go-openapi/swag/yamlutils** v0.25.5 -> v0.26.0 - **github.com/go-openapi/validate** v0.25.2 -> v0.25.3 - **github.com/google/certificate-transparency-go** v1.3.2 -> v1.3.3 - **github.com/google/go-containerregistry** v0.20.7 -> v0.21.6 - **github.com/gorilla/mux** v1.8.1 ***new*** - **github.com/grpc-ecosystem/grpc-gateway/v2** v2.28.0 -> v2.29.0 - **github.com/in-toto/attestation** v1.1.2 -> v1.2.0 - **github.com/moby/buildkit** v0.30.0 -> v0.31.0 - **github.com/moby/policy-helpers** [`a39d601`](docker/buildx@a39d60132186) -> [`d5411a9`](docker/buildx@d5411a945cfc) - **github.com/moby/sys/sequential** v0.6.0 -> v0.7.0 - **github.com/pelletier/go-toml/v2** v2.2.4 -> v2.3.1 - **github.com/prometheus/common** v0.66.1 -> v0.67.5 - **github.com/prometheus/procfs** v0.17.0 -> v0.20.1 - **github.com/secure-systems-lab/go-securesystemslib** v0.10.0 -> v0.11.0 - **github.com/sigstore/protobuf-specs** v0.5.0 -> v0.5.1 - **github.com/sigstore/rekor** v1.5.0 -> v1.5.2 - **github.com/sigstore/rekor-tiles/v2** v2.0.1 -> [`5d098a2`](docker/buildx@5d098a2b6443) - **github.com/sigstore/sigstore** v1.10.5 -> v1.10.8 - **github.com/sigstore/sigstore-go** v1.1.4 -> v1.2.1 - **github.com/sigstore/timestamp-authority/v2** v2.0.6 -> v2.1.2 - **github.com/theupdateframework/go-tuf/v2** v2.4.1 -> v2.4.2 - **github.com/tonistiigi/fsutil** [`a2aa163`](docker/buildx@a2aa163d723f) -> [`0257b33`](docker/buildx@0257b3308df4) - **github.com/transparency-dev/formats** [`404c0d5`](docker/buildx@404c0d5b696c) -> v0.1.1 - **github.com/youmark/pkcs8** [`a2c0da2`](docker/buildx@a2c0da244d78) ***new*** - **go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc** v0.68.0 -> v0.69.0 - **go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace** v0.68.0 -> v0.69.0 - **go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp** v0.68.0 -> v0.69.0 - **go.opentelemetry.io/otel** v1.43.0 -> v1.44.0 - **go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc** v1.43.0 -> v1.44.0 - **go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp** v1.43.0 -> v1.44.0 - **go.opentelemetry.io/otel/exporters/otlp/otlptrace** v1.43.0 -> v1.44.0 - **go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc** v1.43.0 -> v1.44.0 - **go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp** v1.43.0 -> v1.44.0 - **go.opentelemetry.io/otel/exporters/stdout/stdouttrace** v1.42.0 -> v1.44.0 - **go.opentelemetry.io/otel/metric** v1.43.0 -> v1.44.0 - **go.opentelemetry.io/otel/sdk** v1.43.0 -> v1.44.0 - **go.opentelemetry.io/otel/sdk/metric** v1.43.0 -> v1.44.0 - **go.opentelemetry.io/otel/trace** v1.43.0 -> v1.44.0 - **go.yaml.in/yaml/v2** v2.4.3 -> v2.4.4 - **google.golang.org/genproto/googleapis/api** [`6f92a3b`](docker/buildx@6f92a3bedf2d) -> [`3dc84a4`](docker/buildx@3dc84a4a5aaa) - **google.golang.org/genproto/googleapis/rpc** [`6f92a3b`](docker/buildx@6f92a3bedf2d) -> [`3dc84a4`](docker/buildx@3dc84a4a5aaa) - **google.golang.org/grpc** v1.80.0 -> v1.81.1 - **google.golang.org/grpc/cmd/protoc-gen-go-grpc** v1.5.1 -> v1.6.1 - **k8s.io/klog/v2** v2.130.1 -> v2.140.0 Previous release can be found at [v0.34.1](https://github.com/docker/buildx/releases/tag/v0.34.1) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - Between 12:00 AM and 03:59 AM (`* 0-3 * * *`) - Automerge - Between 12:00 AM and 03:59 AM (`* 0-3 * * *`) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yNTIuMSIsInVwZGF0ZWRJblZlciI6IjQzLjI1Mi4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJLaW5kL0RlcGVuZGVuY3lVcGRhdGUiLCJydW4tZW5kLXRvLWVuZC10ZXN0cyJdfQ==--> Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/1603
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildx support for moby/buildkit#6740
Evaluate source policy caps before solve requests so policies can enable
BuildKit proxy networking. Policy can return caps {"exec.proxy": true}
during the caps request to enable proxy network
support for the solve.