Add .IPAddresses as formatting option on docker ps #2733
Conversation
|
Had this branch on my computer; not sure if we should merge (see discussion on moby/moby#8786), but thought to at least push it to github 😂 |
thaJeztah
force-pushed
the
ps_ip_address_details
branch
from
d5ebad2 to
72a56bd
Compare
thaJeztah
force-pushed
the
ps_ip_address_details
branch
from
72a56bd to
d24907b
Compare
|
Are there any blockers (unrelated to Moby) to get this PR merged into Docker CLI? I think this would make the |
|
I want to have another look at this (also taking into account IPv6 addresses); slightly wondering if the
I think this was done to decorate the struct with formatting functions (such as this one); the formatting is meant for "printing on the CLI", and is kinda separate from both "client" and "api", so may not be very suitable for inclusion in the upstream moby repository (as part of the types) |
|
right, I've been confused by the naming used on |
thaJeztah
force-pushed
the
ps_ip_address_details
branch
from
d24907b to
654ba31
Compare
thaJeztah
force-pushed
the
ps_ip_address_details
branch
from
654ba31 to
63e3c5a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
thaJeztah
force-pushed
the
ps_ip_address_details
branch
from
63e3c5a to
f43ec0e
Compare
Add a custom join function that allows for non-string slices to be
joined, following the same rules as "fmt.Sprint", it will use the
fmt.Stringer interface if implemented, or "error" if the type has
an "Error()".
For maps, it joins the map-values, for example:
docker image inspect --format '{{join .Config.Labels ", "}}' ubuntu
24.04, ubuntu
Signed-off-by: Sebastiaan van Stijn <[email protected]>
This allows showing the IP address for each network that the container is attached to,
for example:
docker network create foo
docker run -d --name foo nginx:alpine
docker network connect foo foo
container container ls --format 'table {{.ID}}\\t{{join .IPAddresses ", "}}'
CONTAINER ID IP ADDRESSES
17e7d1910fc0 bridge:172.17.0.2, foo:172.19.0.2
container container ls --format='{{json .IPAddresses}}' | jq .
[
"bridge:172.17.0.2",
"foo:172.19.0.2"
]
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Still failing when joining;
docker container ls --format 'table {{.ID}}\t{{join .IPAddresses ", "}}'
CONTAINER ID IP ADDRESSES
245bd1d81375 bridge/172.17.0.2, foo/172.19.0.2
docker container ls --format '{{json .IPAddresses}}'
[{"Network":"bridge","IP":"172.17.0.2"},{"Network":"foo","IP":"172.19.0.2"}]
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
ps_ip_address_details
branch
from
f43ec0e to
0e8f85c
Compare
|
This still needs a bit of work, and I'll probably split the first commit, but was rebasing old PRs, and trying to make it work and a bit more flexible than just a string |
fixes moby/moby#8786
This allows showing the IP address for each network that the container is attached to,
for example:
- Description for the changelog