vendor: github.com/docker/docker v27.0-dev (018d93decfb5) #5180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
full diff: moby/moby@1a1f3cf...018d93d Signed-off-by: Paweł Gronowski <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5180 +/- ##
==========================================
- Coverage 61.76% 61.73% -0.04%
==========================================
Files 297 294 -3
Lines 20768 20763 -5
==========================================
- Hits 12828 12817 -11
- Misses 7024 7027 +3
- Partials 916 919 +3 |
|
Hm... looks like the linter isn't happy because we're copying locks somewhere 😬 |
|
Hmm right, |
thaJeztah
reviewed
Jun 20, 2024
cli/command/container/client_test.go
Outdated
Comment on lines
17
to
18
| type fakeClient struct { | ||
| client.Client | ||
| client.APIClient |
There was a problem hiding this comment.
I guess one of the tests is now trying to call the interface somewhere 🤔 (which panics);
#20 61.64 === FAIL: cli/command/container TestNewCreateCommandWithContentTrustErrors (0.00s)
#20 61.64 panic: runtime error: invalid memory address or nil pointer dereference [recovered]
#20 61.64 panic: runtime error: invalid memory address or nil pointer dereference
#20 61.64 [signal SIGSEGV: segmentation violation code=0x1 addr=0x178 pc=0xc91b5e]
#20 61.64
#20 61.64 goroutine 77 [running]:
#20 61.64 testing.tRunner.func1.2({0xd84e20, 0x16e8a50})
#20 61.64 /usr/local/go/src/testing/testing.go:1545 +0x238
#20 61.64 testing.tRunner.func1()
#20 61.64 /usr/local/go/src/testing/testing.go:1548 +0x397
#20 61.64 panic({0xd84e20?, 0x16e8a50?})
#20 61.64 /usr/local/go/src/runtime/panic.go:914 +0x21f
#20 61.64 github.com/docker/cli/cli/command/container.(*fakeClient).DaemonHost(0xec5ac1?)
#20 61.64 <autogenerated>:1 +0x1e
#20 61.64 github.com/docker/cli/cli/command/container.runCreate({0x103af40, 0x1740aa0}, {0x1043c28?, 0xc0003a0240?}, 0x0?, 0xc0003be000, 0xc0003f4b00)
#20 61.64 /go/src/github.com/docker/cli/cli/command/container/create.go:88 +0xee
#20 61.64 github.com/docker/cli/cli/command/container.NewCreateCommand.func1(0xc0003ae100?, {0xc0003f2320?, 0x4?, 0xec2c34?})
#20 61.64 /go/src/github.com/docker/cli/cli/command/container/create.go:58 +0x125
#20 61.64 github.com/docker/cli/vendor/github.com/spf13/cobra.(*Command).execute(0xc000004300, {0xc0003f2190, 0x1, 0x1})
#20 61.64 /go/src/github.com/docker/cli/vendor/github.com/spf13/cobra/command.go:985 +0xabc
#20 61.64 github.com/docker/cli/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0xc000004300)
#20 61.64 /go/src/github.com/docker/cli/vendor/github.com/spf13/cobra/command.go:1117 +0x3ff
#20 61.64 github.com/docker/cli/vendor/github.com/spf13/cobra.(*Command).Execute(...)
#20 61.64 /go/src/github.com/docker/cli/vendor/github.com/spf13/cobra/command.go:1041
#20 61.64 github.com/docker/cli/cli/command/container.TestNewCreateCommandWithContentTrustErrors(0x0?)
#20 61.64 /go/src/github.com/docker/cli/cli/command/container/create_test.go:240 +0x1ec
#20 61.64 testing.tRunner(0xc0003dc340, 0xf39900)
#20 61.64 /usr/local/go/src/testing/testing.go:1595 +0xff
#20 61.64 created by testing.(*T).Run in goroutine 1
#20 61.64 /usr/local/go/src/testing/testing.go:1648 +0x3ad
There was a problem hiding this comment.
Yeah, thought it wouldn't do that 😅
I'll just change these fakeClient to be passed via a pointer then.
There was a problem hiding this comment.
If that works for now, I think that's ok to do.
Perhaps we should look later to see if we could actually embed the interface; technically it currently means that "fake" may "not be so fake" and thus call the actual Client; and I'm not sure if that's intentional everywhere or not 🤔
There was a problem hiding this comment.
Will open a separate PR that we can work on later
The embedded `client.Client` has mutexes and it shouldn't be copied. Signed-off-by: Paweł Gronowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
full diff: moby/moby@1a1f3cf...018d93d
Signed-off-by: Paweł Gronowski [email protected]