cli: make initializing the global meter- and tracing providers optional #5188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
status/2-code-review
area/metrics
area/metrics/otel
area/go-sdk
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5188 +/- ##
==========================================
- Coverage 61.74% 61.42% -0.32%
==========================================
Files 297 298 +1
Lines 20787 20797 +10
==========================================
- Hits 12835 12775 -60
- Misses 7037 7109 +72
+ Partials 915 913 -2 |
krissetto
approved these changes
Jun 24, 2024
| @@ -92,6 +92,8 @@ type DockerCli struct { | |||
| // this may be replaced by explicitly passing a context to functions that | |||
| // need it. | |||
| baseCtx context.Context | |||
|
|
|||
| enableGlobalMeter, enableGlobalTracer bool | |||
There was a problem hiding this comment.
nit: we should probably call these Meter/TracerProvider
There was a problem hiding this comment.
Yeah, they were already far too long names for an un-exported field 😂
thaJeztah
force-pushed
the
tracer_meter_optional
branch
from
13addd4 to
947effd
Compare
thaJeztah
commented
Jun 24, 2024
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
tracer_meter_optional
branch
from
947effd to
617eb52
Compare
vvoland
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)