cli/command: remove uses of GetAuthConfigKey, ParseRepositoryInfo #5942
Conversation
Re-implement locally, based on the code in github.com/docker/docker/registry, but leaving out bits that are not used on the client-side, such as configuration of Mirrors, and configurable insecure-registry, which are not used on the client side. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
kind/refactor
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #5942 +/- ##
==========================================
- Coverage 59.43% 59.39% -0.04%
==========================================
Files 358 358
Lines 29769 29775 +6
==========================================
- Hits 17694 17686 -8
- Misses 11107 11122 +15
+ Partials 968 967 -1 🚀 New features to boost your workflow:
|
|
Thanks! |
| // a copy of [registry.IndexServer]. | ||
| // | ||
| // [registry.IndexServer]: https://pkg.go.dev/github.com/docker/docker/registry#IndexServer | ||
| const authConfigKey = "https:/index.docker.io/v1/" |
There was a problem hiding this comment.
A drive-by comment: This should have // in https://.
There was a problem hiding this comment.
OMG! 🙈 Would that be it??
I was looking over the code multiple times to see where I went wrong, and this ... definitely could be it!
I'm not sure we ever met in person, but if we do (I hope we will, one day), I owe you a 🍻 (or any other beverage) ❤️
Re-implement locally, based on the code in github.com/docker/docker/registry, but leaving out bits that are not used on the client-side, such as configuration of Mirrors, and configurable insecure-registry, which are not used on the client side.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)