opts: deprecate ListOpts.GetAll in favor of ListOpts.GetSlice #6032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
impact/changelog
impact/deprecation
status/2-code-review
area/go-sdk
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6032 +/- ##
=======================================
Coverage 58.91% 58.91%
=======================================
Files 358 358
Lines 29983 29983
=======================================
Hits 17664 17664
Misses 11339 11339
Partials 980 980 🚀 New features to boost your workflow:
|
The `GetSlice()` function is part of cobra's [cobra.SliceValue] interface, and duplicates the older `GetAll()` method. This patch deprecates the `GetAll()` method in favor of `GetSlice()`. [cobra.SliceValue]: https://pkg.go.dev/github.com/spf13/[email protected]#SliceValue Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
deprecate_ListOpts_GetAll
branch
from
d4fc292 to
5215b1e
Compare
laurazard
approved these changes
Apr 23, 2025
|
Thx! Let me bring this one in 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on:
The
GetSlice()function is part of cobra's cobra.SliceValue interface,and duplicates the older
GetAll()method. This patch deprecates theGetAll()method in favor ofGetSlice().- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)