cli/command: deprecate RegistryAuthenticationPrivilegedFunc #6184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Benehiko
changed the title
thaJeztah
added
impact/changelog
area/go-sdk
This patch deprecates the unused `RegistryAuthenticationPrivilegedFunc`. The function would prompt the user when the registry returns a 403 after trying the initial auth value set in `RegistryAuth`. Signed-off-by: Alano Terblanche <[email protected]>
thaJeztah
force-pushed
the
deprecate-prompt-privilege-func
branch
from
d28f534 to
29263e8
Compare
|
Did a quick rebase after #6174 was merged; CI should go green now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch deprecates the unused
RegistryAuthenticationPrivilegedFunc. The function would prompt the user when the registry returns a 403 after trying the initial auth value set inRegistryAuth.Relates to:
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)