cli/command/image: move build-context detection to build #6189
+71
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
status/2-code-review
area/builder
area/builder/classic-builder
kind/refactor
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
thaJeztah
force-pushed
the
cleanup_build_context
branch
2 times, most recently
from
818a642 to
246be82
Compare
vvoland
approved these changes
Jul 16, 2025
| type ContextType string | ||
|
|
||
| const ( | ||
| ContextTypeStdIn ContextType = "stdin" // ContextTypeStdIn indicates that the build-context is a TAR archive passed through STDIN. |
There was a problem hiding this comment.
nit: IMO StdIn looks weird and isn't consistent with the general naming (like os.Stdin).
Suggested change
| ContextTypeStdIn ContextType = "stdin" // ContextTypeStdIn indicates that the build-context is a TAR archive passed through STDIN. | |
| ContextTypeStdin ContextType = "stdin" // ContextTypeStdin indicates that the build-context is a TAR archive passed through STDIN. |
(just an opinion though)
There was a problem hiding this comment.
Ah, yeah, can change; I always read its as standard-in / standard-out, standard-err, not as a single word, but Golang uses os.Stdin, so it makes sense to follow that.
Let me update.
There was a problem hiding this comment.
done! Will merge when CI finishes.
Removes direct imports of github.com/docker/docker/builder in the image package, to be moved later. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
cleanup_build_context
branch
from
246be82 to
260f1db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides the docker CLI, compose also uses this for the classic builder, so we need a place to put this; it's likely out of scope for the client itself, so we may as well put it here for now.
Removes direct imports of github.com/docker/docker/builder in the image package, to be moved later.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)