cli/config: some minor cleanups #6352
Draft
+53
−64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have some more changes in this area, but need to dust it off; let's open these already as a PR 😅
cli/config/configfile: inline getConfiguredCredentialStore
It was a premature abstraction; the "nil" check for the map was redundant,
making it literally a 1-liner, so just inline it.
cli/config/configfile: use more idiomatic receiver name
Use a shorter name, which is more idiomatic, and prevents accidental
shadowing of types or arguments.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)