Skip to content

Set a non-zero timeout for HTTP client communication with plugin backend.#883

Merged
cpuguy83 merged 1 commit intodocker:masterfrom
anusha-ragunathan:set_default_timeout
Feb 16, 2018
Merged

Set a non-zero timeout for HTTP client communication with plugin backend.#883
cpuguy83 merged 1 commit intodocker:masterfrom
anusha-ragunathan:set_default_timeout

Conversation

@anusha-ragunathan
Copy link
Copy Markdown
Contributor

Currently, the timeout is set to 0, which means no timeout. Set it to a
sane default timeout of 30 seconds.

Signed-off-by: Anusha Ragunathan anusha.ragunathan@docker.com

backend.

Currently, the timeout is set to 0, which means no timeout. Set it to a
sane default timeout of 30 seconds.

Signed-off-by: Anusha Ragunathan <anusha.ragunathan@docker.com>
@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 16, 2018

Codecov Report

Merging #883 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #883   +/-   ##
=======================================
  Coverage   52.73%   52.73%           
=======================================
  Files         257      257           
  Lines       16404    16404           
=======================================
  Hits         8650     8650           
  Misses       7183     7183           
  Partials      571      571

Copy link
Copy Markdown
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83 cpuguy83 merged commit a0044ba into docker:master Feb 16, 2018
@GordonTheTurtle GordonTheTurtle added this to the 18.03.0 milestone Feb 16, 2018
nobiit pushed a commit to nobidev/docker-cli that referenced this pull request Nov 19, 2025
Set a non-zero timeout for HTTP client communication with plugin backend.
Upstream-commit: a0044ba
Component: cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants