Skip to content

Fix stack marshaling for Kubernetes#890

Merged
vdemeester merged 1 commit intodocker:masterfrom
silvin-lubecki:fix-kube-stack-marshaling
Feb 20, 2018
Merged

Fix stack marshaling for Kubernetes#890
vdemeester merged 1 commit intodocker:masterfrom
silvin-lubecki:fix-kube-stack-marshaling

Conversation

@silvin-lubecki
Copy link
Copy Markdown
Contributor

- What I did
Fix stack marshaling for Kubernetes.

- How I did it
Add missing inline flag to the compose config struct.

- How to verify it
Try to deploy a stack against Kubernetes on Docker For Mac, it was broken.

- A picture of a cute animal (not mandatory but encouraged)

image

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 20, 2018

Codecov Report

Merging #890 into master will decrease coverage by 1.61%.
The diff coverage is 75%.

@@            Coverage Diff            @@
##           master    #890      +/-   ##
=========================================
- Coverage   54.81%   53.2%   -1.62%     
=========================================
  Files         245     258      +13     
  Lines       15832   16338     +506     
=========================================
+ Hits         8679    8692      +13     
- Misses       6589    7081     +492     
- Partials      564     565       +1

Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
Copy link
Copy Markdown
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :tiger:

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdemeester vdemeester merged commit 7d41d18 into docker:master Feb 20, 2018
@GordonTheTurtle GordonTheTurtle added this to the 18.03.0 milestone Feb 20, 2018
@silvin-lubecki silvin-lubecki deleted the fix-kube-stack-marshaling branch February 20, 2018 15:51
nobiit pushed a commit to nobidev/docker-cli that referenced this pull request Nov 19, 2025
…haling

Fix stack marshaling for Kubernetes
Upstream-commit: 7d41d18
Component: cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants