Simplify the marshaling of compose types.Config#895
Merged
thaJeztah merged 1 commit intodocker:masterfrom Feb 21, 2018
Merged
Conversation
- Add `Version` to `types.Config` - Add a new `Services` types (that is just `[]ServiceConfig`) and add `MarshalYAML` method on it. - Clean other top-level custom marshaling as `Services` is the only one required. Signed-off-by: Vincent Demeester <vincent@sbr.pm>
Collaborator
Author
|
The order of the marshaled |
Member
|
Can we add some filler-code to fill up all the code that was removed? 😂 |
Codecov Report
@@ Coverage Diff @@
## master #895 +/- ##
=========================================
- Coverage 53.24% 53.2% -0.05%
=========================================
Files 258 258
Lines 16357 16343 -14
=========================================
- Hits 8710 8696 -14
Misses 7082 7082
Partials 565 565 |
thaJeztah
approved these changes
Feb 21, 2018
| propertyWarnings(deprecatedProperties)) | ||
| } | ||
| return config, configDetails.Version, nil | ||
| return config, nil |
nobiit
pushed a commit
to nobidev/docker-cli
that referenced
this pull request
Nov 19, 2025
Simplify the marshaling of compose types.Config Upstream-commit: 88ee1a6 Component: cli
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Versiontotypes.ConfigServicestypes (that is just[]ServiceConfig) and addMarshalYAMLmethod on it.Servicesis the only onerequired.
Follow-up of #891 👼
🦁
Signed-off-by: Vincent Demeester vincent@sbr.pm