Skip to content

Conversation

@glours
Copy link
Contributor

@glours glours commented Nov 6, 2023

Add action associated to each managed path

What I did
Improve the configuration output of watch mode to display for each service which action is associated to each managed path

Previous output:

> docker compose watch
[+] Building 0.0s (0/0)                                                                                                                                                                                                  docker:desktop-linux
[+] Running 3/0
 ✔ Container avatars-api-1    Running                                                                                                                                                                                                    0.0s
 ✔ Container avatars-web-1    Running                                                                                                                                                                                                    0.0s
 ✔ Container avatars-proxy-1  Running                                                                                                                                                                                                    0.0s
watching [/Users/glours/sources/avatars/proxy/nginx.conf]
watching [/Users/glours/sources/avatars/api/requirements.txt /Users/glours/sources/avatars/api]
watching [/Users/glours/sources/avatars/web/package.json /Users/glours/sources/avatars/web/yarn.lock /Users/glours/sources/avatars/web]

New one:

docker compose watch
[+] Building 0.0s (0/0)                                                                                                                                                                                                  docker:desktop-linux
[+] Running 3/3
 ✔ Container avatars-web-1    Running                                                                                                                                                                                                    0.0s
 ✔ Container avatars-api-1    Running                                                                                                                                                                                                    0.0s
 ✔ Container avatars-proxy-1  Running                                                                                                                                                                                                    0.0s
Watch configuration for service "api":
  - Action rebuild for path "/Users/glours/sources/avatars/api/requirements.txt"
  - Action rebuild for path "/Users/glours/sources/avatars/api"
Watch configuration for service "web":
  - Action rebuild for path "/Users/glours/sources/avatars/web/package.json"
  - Action rebuild for path "/Users/glours/sources/avatars/web/yarn.lock"
  - Action sync for path "/Users/glours/sources/avatars/web"
Watch configuration for service "proxy":
  - Action sync+restart for path "/Users/glours/sources/avatars/proxy/nginx.conf"

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@glours glours requested a review from ndeloof November 6, 2023 10:29
@glours glours self-assigned this Nov 6, 2023
@glours glours requested a review from milas November 6, 2023 10:33
Add action associated to each managed path

Signed-off-by: Guillaume Lours <[email protected]>
@glours glours force-pushed the improve-watch-logs branch from 2d47bc3 to c77e963 Compare November 6, 2023 10:55
@codecov
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (d646d75) 56.98% compared to head (c77e963) 56.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11161      +/-   ##
==========================================
- Coverage   56.98%   56.97%   -0.02%     
==========================================
  Files         133      133              
  Lines       11364    11370       +6     
==========================================
+ Hits         6476     6478       +2     
- Misses       4264     4269       +5     
+ Partials      624      623       -1     
Files Coverage Δ
pkg/compose/watch.go 35.01% <18.18%> (-1.74%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndeloof ndeloof merged commit e5cd265 into docker:main Nov 6, 2023
@glours glours deleted the improve-watch-logs branch June 30, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants