chore(watch): remove old docker cp implementation
#11497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has not been the default for quite a while and required setting an environment variable to revert back. The tar implementation is more performant and addresses several edge cases with the original `docker cp` version, so it's time to fully retire it. The scaffolding for multiple sync implementations remains to support future experimentation here. Signed-off-by: Milas Bowman <[email protected]>
milas
requested review from
glours,
jhrotko and
ndeloof
and removed request for
a team
ndeloof
approved these changes
Feb 13, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11497 +/- ##
==========================================
+ Coverage 58.34% 58.47% +0.13%
==========================================
Files 136 134 -2
Lines 11587 11508 -79
==========================================
- Hits 6760 6729 -31
+ Misses 4166 4118 -48
Partials 661 661 ☔ View full report in Codecov by Sentry. |
glours
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Remove the original
docker cpimplementation for Watch mode synchronization.This has not been the default for quite a while and required setting an environment variable to revert back.
The tar implementation is more performant and addresses several edge cases with the original
docker cpversion, so it's time to fully retire it.The scaffolding for multiple sync implementations remains to support future experimentation here.
Related issue
JIRA: COMP-385
(not mandatory) A picture of a cute animal, if possible in relation to what you did
