Fix pulling with container create api

[BeardedDonut]

Fix the pulling issue stated in #2635. Basically, similar to docker create it should pull the image if it does not exist locally.

[dan-hipschman]

I would like to see the Python SDK and Docker CLI behavior in sync, so support this PR, but should point out that the current difference is documented:

docker-py/docker/models/containers.py

Lines 846 to 858 in b37a25d

	def create(self, image, command=None, **kwargs):
	"""
	Create a container without starting it. Similar to ``docker create``.
	Takes the same arguments as :py:meth:`run`, except for ``stdout``,
	``stderr``, and ``remove``.
	Returns:
	A :py:class:`Container` object.
	Raises:
	:py:class:`docker.errors.ImageNotFound`
	If the specified image does not exist.

This PR should at least update the documentation and ContainerCollection.run (which can call create twice). Then the maintainers can decide whether they want to change the documented behavior.

[BeardedDonut]

@dan-hipschman-od Thanks for your comment, I just didn't get this part would you please clarify a bit.

This PR should at least update the documentation and ContainerCollection.run (which can call create twice). Then the maintainers can decide whether they want to change the documented behavior.

Thanks.

[dan-hipschman]

Yea, I was just saying two things:

• Could you update the documentation of ContainerCollection.create so it says it will try to pull the image if it doesn't exist locally?
• And ContainerCollection.run currently calls create and assumes it will not pull the image, so run itself catches ImageNotFound and tries to pull the image (see below). Since you're changing create to pull the image, then run can be simplified:
  

  docker-py/docker/models/containers.py

  Lines 808 to 814 in b37a25d

  	try:
  	container = self.create(image=image, command=command,
  	detach=detach, **kwargs)
  	except ImageNotFound:
  	self.client.images.pull(image, platform=platform)
  	container = self.create(image=image, command=command,
  	detach=detach, **kwargs)

[milas]

Thanks for the PR!

I'm going to echo the great feedback already provided by @dan-hipschman-od:

Yea, I was just saying two things:

• Could you update the documentation of ContainerCollection.create so it says it will try to pull the image if it doesn't exist locally?
• And ContainerCollection.run currently calls create and assumes it will not pull the image, so run itself catches ImageNotFound and tries to pull the image (see below). Since you're changing create to pull the image, then run can be simplified:
  

  docker-py/docker/models/containers.py

  Lines 808 to 814 in b37a25d

  	try:
  	container = self.create(image=image, command=command,
  	detach=detach, **kwargs)
  	except ImageNotFound:
  	self.client.images.pull(image, platform=platform)
  	container = self.create(image=image, command=command,
  	detach=detach, **kwargs)