Skip to content

Markdown to HTML regressions from Hugo to Jekyll #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
londoncalling opened this issue Nov 1, 2016 · 3 comments
Closed

Markdown to HTML regressions from Hugo to Jekyll #414

londoncalling opened this issue Nov 1, 2016 · 3 comments
Assignees

Comments

@londoncalling
Copy link
Contributor

londoncalling commented Nov 1, 2016

Problem description

We've had a few regressions in how markdown converts to HTML since the switch to Jekyll. Here are two I've seen so far:

  1. URLs do not automatically convert to links unless they are explicitly formatted as such, either with <a href="link">link text</a>, or in markdown with link text`

  2. On-page links do not convert properly (e.g., #what-you-can-do)

See PR #413 for examples.

@johndmulhausen
Copy link

johndmulhausen commented Nov 2, 2016

Issue #2 fixed in 47de0e2

Re: Issue #1 I think the explicit formatting of links is an okay expectation to set? There are probably cases where we don't necessarily want to make things a link, like http://example.com or http://localhost right?

@johndmulhausen johndmulhausen self-assigned this Nov 2, 2016
@londoncalling
Copy link
Contributor Author

londoncalling commented Nov 2, 2016

@johndmulhausen sounds great! Closing the issue, thanks! cc'ing @mstanleyjones

joaofnfernandes pushed a commit to joaofnfernandes/docker.github.io that referenced this issue Apr 16, 2018
JimGalasyn pushed a commit that referenced this issue Apr 16, 2018
@docker-robott
Copy link
Collaborator

Closed issues are locked after 30 days of inactivity.
This helps our team focus on active issues.

If you have found a problem that seems similar to this, please open a new issue.

/lifecycle locked

@docker docker locked and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants