Additional Docker for Windows documentation added #12877
Conversation
- One paragraph was double, so I merged these two. - Reasoning added to note on context-less effects.
|
Deploy Preview for docsdocker ready! Built with commit e12c58f |
SetTrend
force-pushed
the
docker-for-windows
branch
4 times, most recently
from
24ccc6f to
5e9f296
Compare
SetTrend
force-pushed
the
docker-for-windows
branch
from
5e9f296 to
e12c58f
Compare
usha-mandya
added
the
area/desktop
|
Hi @SetTrend For other reviewers: The new page can be found at https://deploy-preview-12877--docsdocker.netlify.app/docker-for-windows/mounts-on-windows/ |
| toc_min: 1 | ||
| toc_max: 2 | ||
| redirect_from: | ||
| - /engine/admin/volumes/mounts-on-windows/ |
There was a problem hiding this comment.
I'm not sure we need this redirect.
| @@ -365,6 +365,8 @@ guides: | |||
| title: Volumes | |||
| - path: /storage/bind-mounts/ | |||
| title: Bind mounts | |||
| - path: /docker-for-windows/mounts-on-windows/ | |||
There was a problem hiding this comment.
For me it feels like the page path should be /storage/mounts-on-windows/ as it's listed in the storage section and not in the docker-for-windows section.
@usha-mandya WDYT?
I understand that this page is specific to Docker Desktop for Windows, so it may be listed there as well? 🤔
There was a problem hiding this comment.
Agree. We can add a link to this page from the Docker Desktop for Windows page.
There was a problem hiding this comment.
I'm a bit uncertain about whether I am supposed to change something at this stage. To me it looks like you're still in an internal discussion?
I'll gladly change things to your discretion (or leave it up to you, of course). Just address me imperatively when you feel it's time I can do something to amend the PR.
|
@StefanScherer: Do you believe we'll get any progress here? |
|
Ping. |
|
Hey @SetTrend I'm sorry for the delay. Thanks again for you enthusiasm to write down all the details for Windows. Our docs team an PMs came to the conclusion that we don't want to add all these details to our docs, because it would be hard to maintain it and keep it in sync if our engineering team decides to change the internals of Docker Desktop. Maybe it's better for now that you put these details in a blog post and share it with the community? |
|
Very disappointing ... Would you mind if I took my version of the whole documentation as a base and publish it on my website, focussing Windows developers? Introduced by a corresponding disclaimer, of course? |
|
Sorry about the delay. I still would recommend to write a detailed blog post to share it with your community. The docs repo is Apache licensed, please refer to that what you can do. I just wonder how you plan to keep it in sync with upstream changes when you host them on a different site. |
Proposed changes
I merged my previous pull requests for improving Docker for Windows documentation into this single pull request.
It seems to me that approving Docker for Windows documentation is stalling quite a bit. So, instead of submitting numerous amendments to the current documentation I now turned to unite my additions into this single pull request here to keep the administrative efforts at a minimum for me while still sharing the additional information through the preview website auto-generated by this pull request.
Related pull requests
#12876
#12796