-
Notifications
You must be signed in to change notification settings - Fork 7.7k
DKP-312: Add release notes for 4.12.0 #15503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update release notes to reflect latest change to Docker Compose, v2.10.2
Introduced release notes from PR docker#18825
✅ Deploy Preview for docsdocker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found an issue (left comment inline)
@andrei-z-albu thank you for submitting the PR. Once the structural issues have been addressed (distributing some of the items from the 'New' section, and Sebastiaan's comment) then I can do a more thorough review to make sure it aligns with our Style Guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven’t checked all entries, but I think we should first move most of the New ones to the proper sections, like @aevesdocker suggested, before we can have a more thorough look.
desktop/release-notes.md
Outdated
- Added the experimental docker daemon with the containerd image store. | ||
- Allow Docker Desktop to run untagged image (https://github.com/docker/for-mac/issues/6425) | ||
- Add search capabilities to Docker Extension Marketplace. Fixes [docker/roadmap#346](https://github.com/docker/roadmap/issues/346). | ||
- [mac] Quit Docker Desktop completely from the Dock menu (https://github.com/docker/for-mac/issues/6440) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks like a bug fix for the Mac section below?
Also the phrasing is a little odd…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, I'll move it to the Mac section. Not sure about the phrasing though, perhaps make it much more explicit like:
Quit Docker Desktop completely from the Dock menu, to ensure Docker Desktop isn't running in the background without the whale icon in the menu bar visible. Fixes [https://github.com/docker/for-mac/issues/6440]
Moved certain entries from the New section to the Bug fixes and minor changes one. Also replaced the {% include desktop-install.html %} section from 4.11.1 with the chunk of relevant links to installers and checksums
Fix phrasing where relevant, as evidenced in the last code review
@aevesdocker I have moved the entries you have mentioned to the relevant section, and updated the 4.11.1 part with the relevant installer links and checksums, as per @thaJeztahs' comment. There are still a few unresolved questions, perhaps a more thorough review of yours could shed some light on these, so we push out clear and consistent release notes |
Added security fixes release notes from @gabrielageorgieva. Fixed a few texts as follow up from code review
Co-authored-by: Allie Sadler <[email protected]>
Co-authored-by: Allie Sadler <[email protected]>
Co-authored-by: Allie Sadler <[email protected]>
Co-authored-by: Allie Sadler <[email protected]>
Co-authored-by: Allie Sadler <[email protected]>
Co-authored-by: Allie Sadler <[email protected]>
Co-authored-by: Allie Sadler <[email protected]>
Co-authored-by: Allie Sadler <[email protected]>
Co-authored-by: Allie Sadler <[email protected]>
Co-authored-by: Allie Sadler <[email protected]>
Co-authored-by: Allie Sadler <[email protected]>
Co-authored-by: Allie Sadler <[email protected]>
Co-authored-by: Allie Sadler <[email protected]>
Co-authored-by: Allie Sadler <[email protected]>
Co-authored-by: Allie Sadler <[email protected]>
Co-authored-by: Allie Sadler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @andrei-z-albu! This LGTM
Added checksums for 4.12 installer files, and updated links to point to 4.12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
Related issues (optional)