Skip to content

DKP-312: Add release notes for 4.12.0 #15503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Sep 1, 2022
Merged

Conversation

andrei-z-albu
Copy link
Member

Proposed changes

Related issues (optional)

Update release notes to reflect latest change to Docker Compose, v2.10.2
Introduced release notes from PR docker#18825
@netlify
Copy link

netlify bot commented Aug 27, 2022

Deploy Preview for docsdocker ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1e1bfb6
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6310babeb9f1eb0009fffef1
😎 Deploy Preview https://deploy-preview-15503--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@andrei-z-albu andrei-z-albu marked this pull request as draft August 27, 2022 06:25
@andrei-z-albu andrei-z-albu marked this pull request as ready for review August 27, 2022 06:29
@thaJeztah thaJeztah added this to the DD 4.12 milestone Aug 28, 2022
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found an issue (left comment inline)

@thaJeztah thaJeztah added area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/release-notes Release Notes labels Aug 28, 2022
@aevesdocker
Copy link
Contributor

@andrei-z-albu thank you for submitting the PR. Once the structural issues have been addressed (distributing some of the items from the 'New' section, and Sebastiaan's comment) then I can do a more thorough review to make sure it aligns with our Style Guide

Copy link
Member

@mat007 mat007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven’t checked all entries, but I think we should first move most of the New ones to the proper sections, like @aevesdocker suggested, before we can have a more thorough look.

- Added the experimental docker daemon with the containerd image store.
- Allow Docker Desktop to run untagged image (https://github.com/docker/for-mac/issues/6425)
- Add search capabilities to Docker Extension Marketplace. Fixes [docker/roadmap#346](https://github.com/docker/roadmap/issues/346).
- [mac] Quit Docker Desktop completely from the Dock menu (https://github.com/docker/for-mac/issues/6440)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks like a bug fix for the Mac section below?
Also the phrasing is a little odd…

Copy link
Member Author

@andrei-z-albu andrei-z-albu Aug 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I'll move it to the Mac section. Not sure about the phrasing though, perhaps make it much more explicit like:
Quit Docker Desktop completely from the Dock menu, to ensure Docker Desktop isn't running in the background without the whale icon in the menu bar visible. Fixes [https://github.com/docker/for-mac/issues/6440]

Moved certain entries from the New section to the Bug fixes and minor changes one. Also replaced the {% include desktop-install.html %} section from 4.11.1 with the chunk of relevant links to installers and checksums
Fix phrasing where relevant, as evidenced in the last code review
@andrei-z-albu
Copy link
Member Author

@aevesdocker I have moved the entries you have mentioned to the relevant section, and updated the 4.11.1 part with the relevant installer links and checksums, as per @thaJeztahs' comment. There are still a few unresolved questions, perhaps a more thorough review of yours could shed some light on these, so we push out clear and consistent release notes

@andrei-z-albu andrei-z-albu requested review from mat007 and removed request for usha-mandya August 31, 2022 10:42
Added security fixes release notes from @gabrielageorgieva. Fixed a few texts as follow up from code review
@andrei-z-albu andrei-z-albu requested review from aevesdocker and removed request for mat007 September 1, 2022 08:05
aevesdocker
aevesdocker previously approved these changes Sep 1, 2022
Copy link
Contributor

@aevesdocker aevesdocker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @andrei-z-albu! This LGTM

aevesdocker
aevesdocker previously approved these changes Sep 1, 2022
Added checksums for 4.12 installer files, and updated links to point to 4.12
Copy link
Member

@StefanScherer StefanScherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aevesdocker aevesdocker merged commit 6c073b3 into docker:master Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/release-notes Release Notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants