dhi: update customizations#24503
Conversation
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR correctly updates the package customization documentation to reflect the version-specific behavior of Docker Hardened Images. The change clarifies that Alpine 3.23 has hardened packages while Alpine 3.22 and Debian have standard packages, which matches the author's testing.
The removal of bold formatting from "Packages" is a minor style choice. While the style guide permits bolding UI elements, the author chose to simplify the instruction by removing the UI-specific wording, which is reasonable given the dynamic nature of the UI labels across versions.
No issues found in the changed code.
| packages that have been built from source by Docker with cryptographic | ||
| signatures and full supply chain security. For Debian-based images, | ||
| these are standard Debian system packages. | ||
| selected image variant. For version 3.23 Alpine-based images, these are |
There was a problem hiding this comment.
I guess this won't be evergreen - in about two months from now we'll have 3.24 images. So we'll either need to go back here and update at that point, or we rephrase this to say call out say something like Alpine images, except 3.22, contain hardened packages, ...
2 participants
Description
Follow up to #24500. I incorrectly interpreted and tested only the distros and not the distro versions.
The UI wording is dynamic based on distro and version. I removed the UI wording instead of updating as it makes the simple step more complex than necessary by having to explain an insignificant UI quirk. Added the explanation to the paragraph below the main step text.
Debian UI wording is Packages
Alpine 3.22 UI wording is Packages
Alpine 3.23 UI wording is Hardened Packages
Related issues or tickets
ENGDOCS-3218
Reviews