Skip to content

Add custom docker0 configuration examples #2894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ashishkamat2791
Copy link
Contributor

@ashishkamat2791 ashishkamat2791 commented Apr 19, 2017

Proposed changes

Unreleased project version (optional)

Related issues (optional)

Fixes #1946

@johndmulhausen
Copy link

@ashishkamat2791 I'm pretty sure you need to rebase your fork; this PR is looking a bit goofy at the moment. :)

@johndmulhausen johndmulhausen changed the title Ashishkamat2791 patch 1 #1946 Ashishkamat2791 patch 1 Apr 21, 2017
@mdlinville
Copy link

Let me see if I can rebase this for you. :)

@mdlinville mdlinville force-pushed the ashishkamat2791-patch-1--#1946 branch from 97347fc to 231f605 Compare April 21, 2017 16:41
@mdlinville mdlinville changed the base branch from docs-base to master April 21, 2017 16:43
@mdlinville
Copy link

You had raised the PR against docs-base instead of master. All it took was changing the base. If you need to do this again, click the Edit button next to the title of the PR and then change the value of base in the drop-down.

@mdlinville mdlinville changed the title Ashishkamat2791 patch 1 Add custom docker0 configuration examples Apr 21, 2017
Copy link

@mdlinville mdlinville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with edits, thanks!

@mdlinville mdlinville merged commit db000dc into docker:master Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants