Skip to content

Manual scheduling in compose is set w/ "environment" not "labels"#348

Merged
johndmulhausen merged 1 commit intodocker:masterfrom
toolchainx:patch-1
Nov 8, 2016
Merged

Manual scheduling in compose is set w/ "environment" not "labels"#348
johndmulhausen merged 1 commit intodocker:masterfrom
toolchainx:patch-1

Conversation

@toolchainx
Copy link
Copy Markdown
Contributor

Describe the proposed changes

Manual scheduling in compose file is set with "environment" instead of "labels"

Project version

Docker Engine 1.12

@BSWANG
Copy link
Copy Markdown
Contributor

BSWANG commented Oct 28, 2016

@cpuguy83 This typo puzzle me for a long time. The swarm scheduler only judge by "environment" instead of "label".

joaofnfernandes pushed a commit to joaofnfernandes/docker.github.io that referenced this pull request Nov 1, 2016
Creating specs directory; may be moved later
Adding fix for Issue docker#348
Adding in updates for networking
Updating with Dan's comments: removing old -beta
Updating networking after talking to Madhu
Updated install with HA as optional
Moved HA spec into specs
Did "customer-facing" HA page
Renamed server > controller in docs
Entering comments from reviewers

Signed-off-by: Mary Anthony <mary@docker.com>
joaofnfernandes pushed a commit to joaofnfernandes/docker.github.io that referenced this pull request Nov 2, 2016
Creating specs directory; may be moved later
Adding fix for Issue docker#348
Adding in updates for networking
Updating with Dan's comments: removing old -beta
Updating networking after talking to Madhu
Updated install with HA as optional
Moved HA spec into specs
Did "customer-facing" HA page
Renamed server > controller in docs
Entering comments from reviewers

Signed-off-by: Mary Anthony <mary@docker.com>
@johndmulhausen
Copy link
Copy Markdown
Contributor

Thank you!

@johndmulhausen johndmulhausen merged commit 5c815e0 into docker:master Nov 8, 2016
joaofnfernandes pushed a commit to joaofnfernandes/docker.github.io that referenced this pull request Nov 11, 2016
Creating specs directory; may be moved later
Adding fix for Issue docker#348
Adding in updates for networking
Updating with Dan's comments: removing old -beta
Updating networking after talking to Madhu
Updated install with HA as optional
Moved HA spec into specs
Did "customer-facing" HA page
Renamed server > controller in docs
Entering comments from reviewers

Signed-off-by: Mary Anthony <mary@docker.com>
@twang2218
Copy link
Copy Markdown
Contributor

Not fully fixed, please check #382 .

@londoncalling londoncalling changed the title Manual scheduling in compose file is set with "environment" instead o… Manual scheduling in compose is set w/ "environment" not "labels" Apr 5, 2017
@londoncalling londoncalling changed the title Manual scheduling in compose is set w/ "environment" not "labels" Manual scheduling in compose is set w/ environment not labels Apr 5, 2017
@londoncalling londoncalling changed the title Manual scheduling in compose is set w/ environment not labels Manual scheduling in compose is set w/ "environment" not "labels" Apr 5, 2017
joaofnfernandes pushed a commit to joaofnfernandes/docker.github.io that referenced this pull request Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants