Docker Cloud: update tag mapping label, some typo fixes #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: LRubin <[email protected]>
pchico83
suggested changes
Oct 26, 2016
| If you configured a regex to select the source, you can reference the | ||
| capture groups and use its result as part of the tag. To learn more, see | ||
| [regexes](automated-build.md#regexes-and-automated-builds). | ||
|
|
||
| * Specify the **Dockerfile location** as a path relative to the root of the source code repository. (If the Dockerfile is at the repository root, leave this path set to `/`.) |
There was a problem hiding this comment.
it is relative to the build context, not to the root
There was a problem hiding this comment.
Context isn't live yet. That update will happen later.
There was a problem hiding this comment.
ok, as long as it is changed before going live.
There was a problem hiding this comment.
That'll be in a separate PR, as discussed. :)
pchico83
approved these changes
Oct 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Tag Mapping label to the new "Build Rules". Plus some copy edits and typo fixes.
@pkennedyr @pchico83
Signed-off-by: LRubin [email protected]