-
Notifications
You must be signed in to change notification settings - Fork 7.7k
added explanation of performance issues on osxfs from @dsheets post #379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added explanation of performance issues on osxfs from @dsheets post #379
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I just have a few small comments. :-) Thanks!
post](https://forums.docker.com/t/file-access-in-mounted-volumes-extremely-slow-cpu-bound/8076/158?u=orangesnap) | ||
from David Sheets (@dsheets) on the [Docker development | ||
team](https://forums.docker.com/groups/Docker) to the forum topic just | ||
mentioned. We wanted to surface it in the documentation for wider reach. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We wanted to surface it in the documentation for wider reach.
reads awkwardly but is probably fine. The text is in the present with the reader.
|
||
These two examples come from performance use cases contributed by users and they | ||
are incredibly helpful in prioritizing aspects of file system performance to | ||
improve. I am personally developing statistical file system trace analysis tools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/I am personally/We are/
|
||
Under development, we have: | ||
|
||
1. A Linux kernel module to reduce data path latency by 2/7 copies and 2/5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/kernel module/kernel patch/
Great @dsheets , thanks. On Tuesday, November 1, 2016, David Sheets [email protected] wrote:
|
@dsheets @thaJeztah @MagnusS @dave-tucker @mstanleyjones @johndmulhausen Can someone give this a final review and approve my changes so I can merge? Thanks! |
updates per @dsheets comments Signed-off-by: Victoria Bialas <[email protected]> copyedits per @dsheets Signed-off-by: Victoria Bialas <[email protected]>
@dsheets :-) how about now? merge if you think it's good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
Added topic on "Performance issues, solutions, and roadmap".
Related issues
issue: https://github.com/docker/pinata/issues/5564
forum topic: https://forums.docker.com/t/file-access-in-mounted-volumes-extremely-slow-cpu-bound/
Please take a look
@samoht @dsheets @justincormack @thaJeztah
Signed-off-by: Victoria Bialas [email protected]