docs(README): Fix date format from 12h to 24h in schedule pattern #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hh represents 12h format from 01 to 12 which is probably not suitable for date tags. The pattern example in the table below uses the 24h format HH, so this makes the document consistent. Signed-off-by: motoki317 <[email protected]>
motoki317
force-pushed
the
docs/fix-to-24h-schedule-pattern
branch
from
6df5f1b to
afd7e6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hh represents 12h format from 01 to 12 which is probably not suitable for date tags.
The pattern example in the table below uses the 24h format HH, so this makes the document consistent.
Feel free to correct me if this was actually intentional!
https://momentjs.com/docs/#/displaying/format/