Skip to content

feat: Fixed char ordering in text lines #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jun 24, 2025
Merged

Conversation

PeterStaar-IBM
Copy link
Contributor

No description provided.

Signed-off-by: Peter Staar <[email protected]>
@PeterStaar-IBM PeterStaar-IBM requested a review from cau-git June 20, 2025 14:42
Copy link

mergify bot commented Jun 20, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

Copy link
Contributor

github-actions bot commented Jun 20, 2025

DCO Check Passed

Thanks @PeterStaar-IBM, all your commits are properly signed off. 🎉

Signed-off-by: Peter Staar <[email protected]>
@cau-git cau-git changed the title feat: fixed the ordering feat: Fixed char ordering in text lines, avoid quadratic loop Jun 20, 2025
PeterStaar-IBM and others added 4 commits June 20, 2025 17:06
Signed-off-by: Peter Staar <[email protected]>
Signed-off-by: Peter Staar <[email protected]>
Signed-off-by: Christoph Auer <[email protected]>
Signed-off-by: Peter Staar <[email protected]>
@cau-git cau-git changed the title feat: Fixed char ordering in text lines, avoid quadratic loop feat: Fixed char ordering in text lines Jun 20, 2025
cau-git
cau-git previously approved these changes Jun 20, 2025
Copy link
Contributor

@cau-git cau-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Peter Staar <[email protected]>
Signed-off-by: Peter Staar <[email protected]>
@PeterStaar-IBM PeterStaar-IBM self-assigned this Jun 20, 2025
Signed-off-by: Peter Staar <[email protected]>
cau-git
cau-git previously approved these changes Jun 21, 2025
@cau-git
Copy link
Contributor

cau-git commented Jun 21, 2025

We have a systematic build issue for windows:

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
d----           6/21/2025  5:55 AM                nasm
Invoke-WebRequest: D:\a\_temp\212c4502-e16a-48d8-81a7-7038d46a1094.ps1:3
Line |
   3 |  Invoke-WebRequest -Uri 'https://fossies.org/windows/misc/nasm-2.16.03 …
     |  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     |          Fossies - The Free Open Source Software Archive: 403 Forbidden (Unwanted Direct Access)        The
     | &quot;Fossies&quot; Software Archive   ...&nbsp;Free&nbsp;Open&nbsp;Source&nbsp;Software mainly&nbsp;for
     | Internet,&nbsp;Engineering&nbsp;and&nbsp;Science&nbsp;...    Sorry, direct access to the server fossies.org is
     | currently not possible. To protect the Fossies server from unwanted and abusive traffic in the interest of real
     | human users,  the server's contents can only be accessed if you either start your browser session on the Fossies
     | homepage  or if you enter a descriptive word or short comment about Fossies here (that will also whitelist your
     | IP address for a while):    &nbsp;&nbsp;                  Your
     | original&nbsp;request:&nbsp;&nbsp;https://fossies.org/windows/misc/nasm-2.16.03-win64.zip/nasm-2.16.03/nasm.exe&nbsp; In case of problems, please send an email to &#105;&#110;&#102;&#111;&#064;&#102;&#111;&#115;&#115;&#105;&#101;&#115;&#046;&#111;&#114;&#103;.Thank you for your understanding!   

looks like the nasm binary is now shielded from being downloaded through a deep link.

Signed-off-by: Peter Staar <[email protected]>
cau-git
cau-git previously approved these changes Jun 23, 2025
Signed-off-by: Peter Staar <[email protected]>
@PeterStaar-IBM PeterStaar-IBM merged commit 8872e73 into main Jun 24, 2025
39 checks passed
@PeterStaar-IBM PeterStaar-IBM deleted the fix/ordering-of-textcells branch June 24, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants