Skip to content

docs(cn): translate src/content/configuration/devtool.md #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 26, 2020
Merged

docs(cn): translate src/content/configuration/devtool.md #761

merged 3 commits into from
Jun 26, 2020

Conversation

weiyuan0609
Copy link

describe your changes...

  • Read and sign the CLA. PRs that haven't signed it won't be accepted.
  • Make sure your PR complies with the writer's guide.
  • Review the diff carefully as sometimes this can reveal issues.
  • Do not abandon your Pull Request: Stale Pull Requests.
  • Remove these instructions from your PR as they are for your eyes only.

@weiyuan0609 weiyuan0609 marked this pull request as draft June 16, 2020 09:55
@netlify
Copy link

netlify bot commented Jun 16, 2020 •
edited
Loading

Deploy preview for cn-webpack ready!

Built with commit 7e0370a

https://deploy-preview-761--cn-webpack.netlify.app

@weiyuan0609 weiyuan0609 marked this pull request as ready for review June 16, 2020 10:12
@weiyuan0609 weiyuan0609 marked this pull request as draft June 16, 2020 10:12
@weiyuan0609 weiyuan0609 marked this pull request as ready for review June 16, 2020 10:13
@QC-L QC-L mentioned this pull request Jun 17, 2020
Closed
49 tasks
QC-L
QC-L reviewed Jun 18, 2020
View reviewed changes
src/content/configuration/devtool.md

devtool | build | rebuild | production | quality
devtool | 构建速度 | 重新构建速度 | 生产环境 | 品质(quality)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

表格部分的更新被覆盖了，请不要直接使用 v4 的文档内容！

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

列表的一些配置是有更改，主要是名字的调整，比如 cheap 前置，这个有注意到。至于提到的不同是指速度描述么，这个 v4 使用 +++--- 来描述的。所以沿用了这个模式，并在下面注释了

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文档不要沿用 v4 的，以新版本为主

@QC-L
Copy link
Member

QC-L commented Jun 18, 2020

行数不对应，请仔细检查修改后 @ 我

@weiyuan0609
Copy link
Author

行数不对应，请仔细检查修改后@我

@QC-L
行数不对是由于沿用之前+++---模式，故需要增加一行注释来解释，所以多了三行

image

@QC-L
Copy link
Member

QC-L commented Jun 18, 2020

不要沿用 v4 的，请以新版本为主！那个是旧版本的，不便于阅读

@weiyuan0609
Copy link
Author

不要沿用 v4 的，请以新版本为主！那个是旧版本的，不便于阅读

👌 已调整

@QC-L QC-L merged commit 779892a into docschina:cn Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QC-L QC-L QC-L approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weiyuan0609 @QC-L