Use v1 tag for all steps #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As pointed out by Christophe Coevoet on Slack, we are building the image twice because we are using different versions. Moreover, the example has been updated upstream to always use v1. That tag will be a moving pointing to the latest version.
greg0ire
requested review from
malarzm,
morozov,
ostrolucky,
SenseException and
stof
morozov
approved these changes
Sep 17, 2020
SenseException
approved these changes
Sep 17, 2020
|
why are we not using docker:// as @stof suggested? |
I couldn't find that image on the hub, so I suppose this is why he used a conditional here. |
|
Will we need to update existing actions manually or is there some mechanism to do that? |
malarzm
approved these changes
Sep 18, 2020
stof
approved these changes
Sep 18, 2020
I'm quite sure you will need to update workflows in other repositories. I don't think they stay linked to the template for some automatic update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by @stof on Slack, we are building the image
twice because we are using different versions. Moreover, the example has
been updated upstream to always use v1. That tag will be a moving
pointing to the latest version.
More details at laminas/automatic-releases#38