Skip to content

Skip parsing annotations containing dashes, such as @Foo-bar, or @Foo- #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 25, 2019
Merged

Skip parsing annotations containing dashes, such as @Foo-bar, or @Foo- #257

merged 7 commits into from
Mar 25, 2019

Conversation

Ocramius
Copy link
Member

Most likely fixes doctrine/collections#180

@Ocramius Ocramius added the bug label Mar 25, 2019
@Ocramius Ocramius added this to the v1.6.1 milestone Mar 25, 2019
@Ocramius Ocramius requested a review from a team March 25, 2019 17:21
@Ocramius Ocramius mentioned this pull request Mar 25, 2019
Closed
@greg0ire
Copy link
Member

Skip parsing annotations containing dashes, such as @Foo-bar, or @Foo

😕 where is the dash in Foo?

@Ocramius Ocramius changed the title Skip parsing annotations containing dashes, such as @Foo-bar, or @Foo Skip parsing annotations containing dashes, such as @Foo-bar, or @Foo- Mar 25, 2019
@Ocramius
Copy link
Member Author

@greg0ire corrected :-)

greg0ire
greg0ire requested changes Mar 25, 2019
View reviewed changes
greg0ire
greg0ire reviewed Mar 25, 2019
View reviewed changes
@Ocramius Ocramius mentioned this pull request Mar 25, 2019
Closed
@Ocramius Ocramius merged commit ccca417 into doctrine:1.6 Mar 25, 2019
@Ocramius Ocramius deleted the fix/skip-annotations-containing-dashes branch March 25, 2019 18:34
Ocramius added a commit that referenced this pull request Mar 25, 2019
@Ocramius
Using void type declaration where applicable in DocLexerTest
fc573eb 
Ref: #257 (comment)
@Ocramius
Copy link
Member Author

Ported to 1.7 via 5cfa972

Ocramius added a commit that referenced this pull request Mar 25, 2019
@Ocramius
Using void type declaration where applicable in DocLexerTest
4bb2e3a 
Ref: #257 (comment)
@Ocramius
Copy link
Member Author

Ported to master via 6403955

@greg0ire greg0ire mentioned this pull request Mar 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees

@stof stof

Labels
bug
Projects
None yet
Milestone
v1.6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Ocramius @greg0ire @stof