Simplify Input Validation #679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove validate property - add `valid?: boolean` property - call `onValidate` and pass message and valid from meta - onValidate is now a place where the `valid` property can be set/changed and `invalidate` called
valid can now be `boolean | { valid?: boolean; message?: string; }`
helperText will show a message if the message value exists. Otherwise,
it'll show the set helperText.
tomdye
reviewed
Mar 4, 2019
Codecov Report
@@ Coverage Diff @@
## master #679 +/- ##
==========================================
- Coverage 99.03% 99.03% -0.01%
==========================================
Files 44 44
Lines 3319 3317 -2
Branches 913 912 -1
==========================================
- Hits 3287 3285 -2
Misses 32 32
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #679 +/- ##
========================================
- Coverage 99.03% 99% -0.03%
========================================
Files 44 44
Lines 3319 3328 +9
Branches 913 918 +5
========================================
+ Hits 3287 3295 +8
- Misses 32 33 +1
Continue to review full report at Codecov.
|
- add customValidator optional property that can be used to trigger custom vaidation checks AFTER native validation succeeds - prevent onValidate from being called when the validation state hasn't changed
tomdye
reviewed
Mar 6, 2019
tomdye
reviewed
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
Description:
Simplify text-input validation
validatepropertyvalid?: boolean | { valid?: boolean; message?: string; }propertyonValidateand pass message and valid from metavalidproperty.