Fixes #2117 #2125
Merged
Fixes #2117 #2125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2117
The main command "tofile", if it has arguments that are enclosed in double quotes, will receive them as independent elements in the args array. When the call to dotnet exec is made to invoke the subcommand "_tofile", if there are any arguments that contain spaces, they will now be regarded as multiple arguments and the subcommand run will have a different set of arguments, ones that do not match the users' intentions.
Uses the existing EscapePath to enclose those parameters that contain spaces with double quotes. The result is that if the paths that are arguments for the "tofile" command (startupassembly or --output) contain spaces, they should now be seen by the subcommand the same as they were in the main command.