Skip to content

Deprecate SerializeAsV2 #3286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 18, 2025
Merged

Deprecate SerializeAsV2 #3286

merged 3 commits into from
Mar 18, 2025

Conversation

martincostello
Copy link
Collaborator

As a path towards OpenAPI v3.1 support (see #3283), deprecate the --serializeasv2/SerializeAsV2 options in favour of a new --openapiversion/OpenApiVersion option that accepts the specification version to use.

This can go out in the same release as #3183.

As a path towards OpenAPI v3.1 support, deprecate the `--serializeasv2`/`SerializeAsV2` options in favour of a new `--openapiversion`/`OpenApiVersion` option that accepts the specification version to use.
@martincostello martincostello added the version-major A change suitable for release in a major version label Mar 4, 2025
@martincostello martincostello added this to the v8.0.0 milestone Mar 4, 2025
@martincostello martincostello mentioned this pull request Mar 4, 2025
12 tasks
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 90.90909% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.84%. Comparing base (114c2f0) to head (ef5ab53).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...SwaggerGen/DependencyInjection/DocumentProvider.cs 66.66% 2 Missing ⚠️
...uckle.AspNetCore.Swagger/SwaggerEndpointOptions.cs 80.00% 1 Missing ⚠️
...c/Swashbuckle.AspNetCore.Swagger/SwaggerOptions.cs 80.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3286      +/-   ##
==========================================
+ Coverage   83.56%   84.84%   +1.28%     
==========================================
  Files          77       77              
  Lines        3224     3221       -3     
  Branches      559      556       -3     
==========================================
+ Hits         2694     2733      +39     
+ Misses        530      488      -42     
Flag Coverage Δ
Linux 66.31% <20.45%> (-17.25%) ⬇️
Windows 66.31% <20.45%> (-17.25%) ⬇️
macOS 83.54% <90.90%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martincostello martincostello marked this pull request as ready for review March 4, 2025 10:11
@martincostello martincostello enabled auto-merge (rebase) March 4, 2025 10:11
Fix using statements and Public API members that went missing in merge with default branch.
auto-merge was automatically disabled March 18, 2025 16:25

Rebase failed

@martincostello martincostello merged commit cb39741 into master Mar 18, 2025
10 checks passed
@martincostello martincostello deleted the deprecate-SerializeAsV2 branch March 18, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version-major A change suitable for release in a major version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants