Fix RangeAttribute behaviour #3449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use invariant culture when values are `double`. - Use `decimal.TryParse()` not `Convert.ToDecimal()` so that invalid values are just ignored like they were before. - Remove duplicate test case.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3449 +/- ##
=======================================
Coverage 93.54% 93.55%
=======================================
Files 110 110
Lines 3829 3833 +4
Branches 713 715 +2
=======================================
+ Hits 3582 3586 +4
Misses 247 247
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR refines RangeAttribute handling by switching to invariant culture for double limits, replacing Convert.ToDecimal with decimal.TryParse, and tidying up tests.
- Swap
Convert.ToDecimalfor culture-awaredecimal.TryParseon stringified limits - Add a unit test to verify invalid range values are ignored
- Remove a duplicated test case in
TheoryData
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/Swashbuckle.AspNetCore.SwaggerGen.Test/SwaggerGenerator/OpenApiSchemaExtensionsTests.cs | Drop duplicate entry; add Apply_Invalid_RangeAttribute_Values test |
| src/Swashbuckle.AspNetCore.SwaggerGen/SchemaGenerator/OpenApiSchemaExtensions.cs | Update ApplyRangeAttribute to use decimal.TryParse and invariant culture |
src/Swashbuckle.AspNetCore.SwaggerGen/SchemaGenerator/OpenApiSchemaExtensions.cs
Show resolved
Hide resolved
This was referenced Jul 28, 2025
This was referenced Dec 30, 2025
Open
Open
Bump Swashbuckle.AspNetCore from 5.6.3 to 9.0.0
koustavcodes/skills-secure-repository-supply-chain#8
Open
Open
Open
Open
Bump Swashbuckle.AspNetCore from 5.6.3 to 9.0.0
trangntt-016/skills-secure-repository-supply-chain#8
Open
Open
Open
Open
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
double.decimal.TryParse()notConvert.ToDecimal()so that invalid values are just ignored like they were before.