-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Simplify release workflow #3503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
With #3502, the release draft can be created in one request, rather than generating the notes and then manually editing them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR simplifies the GitHub release workflow by utilizing the built-in generate_release_notes parameter instead of manually generating and filtering release notes. The change reduces code complexity by eliminating the separate API call to generate notes and the manual filtering logic.
- Removes manual release notes generation and filtering logic
- Uses the built-in
generate_release_notesparameter in thecreateReleaseAPI call - Extracts
target_commitishinto a variable for better code organization
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3503 +/- ##
=======================================
Coverage 94.28% 94.28%
=======================================
Files 110 110
Lines 3816 3816
Branches 722 722
=======================================
Hits 3598 3598
Misses 218 218
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
With #3502, the release draft can be created in one request, rather than generating the notes and then manually editing them.