Skip to content

Disable secrets-outside-env audit#3823

Merged
martincostello merged 1 commit intomasterfrom
disable-secrets-outside-env
Mar 9, 2026
Merged

Disable secrets-outside-env audit#3823
martincostello merged 1 commit intomasterfrom
disable-secrets-outside-env

Conversation

@martincostello
Copy link
Collaborator

This isn't appropriate in most cases as there's no logical environment, and environments are already used in cases where they are.

This isn't appropriate in most cases as there's no logical environment, and environments are already used in cases where they are.
Copilot AI review requested due to automatic review settings March 9, 2026 11:32
@martincostello martincostello enabled auto-merge (squash) March 9, 2026 11:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s zizmor configuration to disable the secrets-outside-env audit, aiming to avoid findings in workflows that don’t have a meaningful GitHub “environment”.

Changes:

  • Disable the secrets-outside-env zizmor rule in the repo-level config.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.93%. Comparing base (b03fdec) to head (cf17ffa).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3823   +/-   ##
=======================================
  Coverage   94.93%   94.93%           
=======================================
  Files         111      111           
  Lines        3886     3886           
  Branches      784      784           
=======================================
  Hits         3689     3689           
  Misses        197      197           
Flag Coverage Δ
Linux 94.93% <ø> (ø)
Windows 94.93% <ø> (ø)
macOS 94.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martincostello martincostello merged commit 95b24f9 into master Mar 9, 2026
18 checks passed
@martincostello martincostello deleted the disable-secrets-outside-env branch March 9, 2026 11:42
This was referenced Mar 10, 2026
This was referenced Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants