Skip to content

Conversation

@laomatt
Copy link

@laomatt laomatt commented Oct 16, 2024

Summary

When I upgraded an app to rails 7, the token controller was not pre loading the session which is necessary for the creation of the token. This is just to make sure the session is created if its not pre loaded.

@guardrails
Copy link

guardrails bot commented Oct 16, 2024

⚠️ We detected 1 security issue in this pull request:

Insecure Use of Language/Framework API (1)
Severity Details Docs
Medium Title: User Controlled Method Invocation
session.send(:load!) if session.id.nil?
📚

More info on how to fix Insecure Use of Language/Framework API in Ruby.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@ThisIsMissEm
Copy link
Contributor

Why's the session needed for the creation of the token? The token creation only relies on the authorization code? You might want to use the before_successful_authorization configuration hook instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants