Skip to content

Provide an AnchorScroll replacement that gives more flexibility. #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jeme opened this issue May 3, 2013 · 3 comments
Closed

Provide an AnchorScroll replacement that gives more flexibility. #15

jeme opened this issue May 3, 2013 · 3 comments
Labels
Milestone

Comments

@jeme
Copy link
Contributor

jeme commented May 3, 2013

This could also be another service that simply used AnchorScroll as default behavior (depending on it) and then extends it.

Things that should be possible is to scroll to elements defined by a route parameter etc.

@jeme
Copy link
Contributor Author

jeme commented May 6, 2013

E.g see: angular-ui/ui-router#110 (comment)

jeme added a commit that referenced this issue May 13, 2013
@jeme
Copy link
Contributor Author

jeme commented Jun 28, 2013

This isn't quite as easy as one could have hoped, as controllers etc. loads data into views causing re-rendering, the scrolling as is may actually scroll to a wrong location.

And waiting for the views to load fully is actually suddenly a difficult task inside Angular's design, unless we provide some sort of "signalling" for the developers to use inside controllers which i just feel is a bad idea all together.

So maybe turning this on it's head and providing the service combined with a directive that can then scroll ones it's element is loaded may provide a better option, although I could still see some cases where it would maybe scroll and then render new content above again causing the scroll location to be wrong.

@jeme
Copy link
Contributor Author

jeme commented Jul 29, 2013

4694bea closes this issue for now, an improvement issue for this has been raised, but for now the functionality is in there at least.

@jeme jeme closed this as completed Jul 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant