Skip to content

Docs for new Negotiate auth handler #12793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 12, 2019
Merged

Docs for new Negotiate auth handler #12793

merged 8 commits into from
Jun 12, 2019

Conversation

Tratcher
Copy link
Member

@Tratcher Tratcher commented Jun 10, 2019

@Tratcher Tratcher requested review from blowdart and HaoK June 10, 2019 21:41
@Tratcher Tratcher self-assigned this Jun 10, 2019
@Tratcher Tratcher requested a review from guardrex June 10, 2019 22:36
@Tratcher
Copy link
Member Author

I know a few of the links don't work yet, they should start working as soon as preview6 gets published.


#### Linux and Mac

Instructions for joining a Linux or Mac machine to a Windows domain can be found at [here](https://docs.microsoft.com/en-us/sql/azure-data-studio/enable-kerberos?view=sql-server-2017#join-your-os-to-the-active-directory-domain-controller). Those instructions create a machine account for the Linux machine on the domain. SPNs will need to be added to that SPN account.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Instructions for joining a Linux or Mac machine to a Windows domain can be found at [here](https://docs.microsoft.com/en-us/sql/azure-data-studio/enable-kerberos?view=sql-server-2017#join-your-os-to-the-active-directory-domain-controller). Those instructions create a machine account for the Linux machine on the domain. SPNs will need to be added to that SPN account.
Instructions for joining a Linux or Mac machine to a Windows domain can be found at [here](https://docs.microsoft.com/en-us/sql/azure-data-studio/enable-kerberos?view=sql-server-2017#join-your-os-to-the-active-directory-domain-controller). Those instructions create a machine account for the Linux machine on the domain. SPNs will need to be added to that account.

@guardrex
Copy link
Collaborator

I'll wait until the PU fully signs off. It's a faster if I apply the handful of grammar+style fixes directly.

@Tratcher I'll ping u after I do that so that you can 👁️ my commit and confirm final touches are ok.

@Tratcher
Copy link
Member Author

@guardrex go ahead. Hao has already signed off and I added Barry more as an FYI.

@guardrex
Copy link
Collaborator

guardrex commented Jun 11, 2019

@Tratcher For sure, confirm that I didn't 💥 break any sentiment there. A few lines were a bit tricky to deal with.

[EDIT] ok ... looks ok thus far if I didn't butcher anything. 🔪

[EDIT] ... and ignore those content validation failures. The tabs are correct. That's a false positive. We merge past that error. cc: @scottaddie - Seems like it's taking the engineers a while to fix that.

[EDIT 😄] Assigning myself to make sure this gets merged at the right 🕐.

@guardrex guardrex self-assigned this Jun 11, 2019
@guardrex
Copy link
Collaborator

I'll take a final look and merge when 🚀 Commander Roth 🚀 pulls the trigger.

@Tratcher
Copy link
Member Author

I'll take a final look and merge when 🚀 Commander Roth 🚀 pulls the trigger.

Why wait?

@guardrex
Copy link
Collaborator

The links are broken, aren't they ... until we go live on Pre6?

@Tratcher
Copy link
Member Author

The nuget links, yes, but they'll fix themselves.

@scottaddie
Copy link
Member

@guardrex It's unlikely that we'll see a fix for that tab content validation error. Tabs are eventually being replaced with zone pivots.

@guardrex
Copy link
Collaborator

guardrex commented Jun 11, 2019

If the NuGet links don't work, then trying to use the package(s) will also fail, right?

I'm too scared 😨 to merge it in this state ... I'm just a contractor! 😄 lol

I'll let management do it ..... or you can.

[EDIT] I messaged them. Let's let them do it. I don't want to get into trouble ... ei ei ei ... more trouble lol.

@tdykstra
Copy link
Contributor

links don't work yet, they should start working as soon as preview6 gets published.

When will that happen? We could go ahead and merge this, and just hold off on merging to Live.

@guardrex
Copy link
Collaborator

guardrex commented Jun 11, 2019

when will that happen

It's variable ... 24 to a few hours prior to formal release.

just hold off on merging to Live.

Yes, but one never knows when another team member is going to pull the trigger. I prefer management make the call on this.

Copy link
Contributor

@blowdart blowdart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor niggles.

Copy link
Collaborator

@guardrex guardrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@guardrex guardrex merged commit 2454a63 into master Jun 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the tratcher/negotiate branch June 12, 2019 15:50
@guardrex guardrex removed their assignment Jun 12, 2019
@Tratcher
Copy link
Member Author

How long does it take docs to go live?

@guardrex
Copy link
Collaborator

errrr...... 🤔 ... I'm trying to get all of the Blazor PRs happily into master (and the sample app checked) first. ....errrrr .... say one hour. Is that ok?

@Tratcher
Copy link
Member Author

Sure, just checking.

@guardrex
Copy link
Collaborator

I'm getting close ... so far, so good. 🤞

@guardrex
Copy link
Collaborator

@Tratcher 🚀 #12849

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs for new Negotiate auth handler
6 participants