EF MVC for 2.0 #4000

tdykstra · 2017-08-16T20:58:44Z

scottaddie · 2017-08-17T01:08:56Z

aspnetcore/data/ef-mvc/advanced.md

-The Contoso University sample web application demonstrates how to create ASP.NET Core 1.0 MVC web applications using Entity Framework Core 1.0 and Visual Studio 2015. For information about the tutorial series, see [the first tutorial in the series](intro.md).
+The Contoso University sample web application demonstrates how to create ASP.NET Core MVC web applications using Entity Framework Core and Visual Studio. For information about the tutorial series, see [the first tutorial in the series](intro.md).

 In the previous tutorial you implemented table-per-hierarchy inheritance. This tutorial introduces several topics that are useful to be aware of when you go beyond the basics of developing ASP.NET web applications that use Entity Framework Core.


Add a comma after "In the previous tutorial".

ASP.NET web applications --> ASP.NET Core applications

scottaddie · 2017-08-17T01:10:46Z

aspnetcore/data/ef-mvc/advanced.md

 ```

-You'll notice something here that might surprise you: the SQL selects up to 2 rows (`TOP(2)`). The `SingleOrDefaultAsync` method doesn't resolve to one row on the server. If the Where clause matches multiple rows, the method must return null, so EF only has to select a maximum of 2 rows, because if 3 or more match the Where clause, the result from the `SingleOrDefault` method is the same as if 2 rows match.
+You'll notice something here that might surprise you: the SQL selects up to 2 rows (`TOP(2)`) from the Person table. The `SingleOrDefaultAsync` method doesn't resolve to one row on the server. If the Where clause matches multiple rows, the method must return null, so EF only has to select a maximum of 2 rows, because if 3 or more match the Where clause, the result from the `SingleOrDefault` method is the same as if 2 rows match.


Spell out the numbers 2 and 3.

Spell out the numbers 2 and 3.

That's old school copy/edit. People prefer numbers.

In a context that includes related numbers (TOP(2)) I prefer to keep them as numbers.

If the Where clause matches multiple rows, the method ~~must~~ return nulls, so EF only has to select a maximum of 2 rows, because if 3 or more match the Where clause, the result from the SingleOrDefault method is the same as if 2 rows match.
Can you break this up into 2 or 3 sentences? It's too long to machine translate.

scottaddie · 2017-08-17T01:12:13Z

aspnetcore/data/ef-mvc/advanced.md

-You'll notice something here that might surprise you: the SQL selects up to 2 rows (`TOP(2)`). The `SingleOrDefaultAsync` method doesn't resolve to one row on the server. If the Where clause matches multiple rows, the method must return null, so EF only has to select a maximum of 2 rows, because if 3 or more match the Where clause, the result from the `SingleOrDefault` method is the same as if 2 rows match.
+You'll notice something here that might surprise you: the SQL selects up to 2 rows (`TOP(2)`) from the Person table. The `SingleOrDefaultAsync` method doesn't resolve to one row on the server. If the Where clause matches multiple rows, the method must return null, so EF only has to select a maximum of 2 rows, because if 3 or more match the Where clause, the result from the `SingleOrDefault` method is the same as if 2 rows match.

 Note that you don't have to use debug mode and stop at a breakpoint to get logging output in the **Output** window. It's just a convenient way to stop the logging at the point you want to look at the output. If you don't do that, logging continues and you have to scroll back to find the parts you're interested in.


Don't end the sentence with a preposition:
~~If you don't do that, logging continues and you have to scroll back to find the parts you're interested in.~~
If you don't do that, logging continues and you have to scroll back to find the parts in which you're interested.

Like many rules including "don't split infinitives", the "don't end with a preposition" rule doesn't reflect actual English usage.

scottaddie · 2017-08-17T01:12:46Z

aspnetcore/data/ef-mvc/complex-data-model.md

 By [Tom Dykstra](https://github.com/tdykstra) and [Rick Anderson](https://twitter.com/RickAndMSFT)

-The Contoso University sample web application demonstrates how to create ASP.NET Core 1.1 MVC web applications using Entity Framework Core 1.1 and Visual Studio 2017. For information about the tutorial series, see [the first tutorial in the series](intro.md).
+The Contoso University sample web application demonstrates how to create ASP.NET Core MVC web applications using Entity Framework Core and Visual Studio. For information about the tutorial series, see [the first tutorial in the series](intro.md).


Convert the link to the "xref" style

I don't mind changing convoluted relative links to xref, but otherwise I don't think we're requiring that every otherwise untouched relative link needs to change to xref.

scottaddie · 2017-08-17T01:13:01Z

aspnetcore/data/ef-mvc/complex-data-model.md

-The Contoso University sample web application demonstrates how to create ASP.NET Core 1.1 MVC web applications using Entity Framework Core 1.1 and Visual Studio 2017. For information about the tutorial series, see [the first tutorial in the series](intro.md).
+The Contoso University sample web application demonstrates how to create ASP.NET Core MVC web applications using Entity Framework Core and Visual Studio. For information about the tutorial series, see [the first tutorial in the series](intro.md).

 In the previous tutorials you worked with a simple data model that was composed of three entities. In this tutorial you'll add more entities and relationships and you'll customize the data model by specifying formatting, validation, and database mapping rules.


Add a comma after "In the previous tutorials" and after "In this tutorial".

scottaddie · 2017-08-17T01:28:00Z

aspnetcore/data/ef-mvc/read-related-data.md

-The Contoso University sample web application demonstrates how to create ASP.NET Core 1.1 MVC web applications using Entity Framework Core 1.1 and Visual Studio 2017. For information about the tutorial series, see [the first tutorial in the series](intro.md).
+The Contoso University sample web application demonstrates how to create ASP.NET Core MVC web applications using Entity Framework Core and Visual Studio. For information about the tutorial series, see [the first tutorial in the series](intro.md).

 In the previous tutorial you completed the School data model. In this tutorial you'll read and display related data -- that is, data that the Entity Framework loads into navigation properties.


Add a comma after "In the previous tutorial" and after "In this tutorial".

scottaddie · 2017-08-17T01:28:57Z

aspnetcore/data/ef-mvc/update-related-data.md


 ### Update the Instructor Edit view

 In *Views/Instructors/Edit.cshtml*, add a new field for editing the office location, at the end before the **Save** button :


Remove the extra space before the colon.

scottaddie · 2017-08-17T01:29:25Z

aspnetcore/data/ef-mvc/update-related-data.md

 <a id="notepad"></a>
 > [!NOTE] 
-> When you paste the code in Visual Studio, line breaks will be changed in a way that breaks the code.  Press Ctrl+Z one time to undo the automatic formatting.  This will fix the line breaks so that they look like what you see here. The indentation doesn't have to be perfect, but the `@</tr><tr>`, `@:<td>`, `@:</td>`, and `@:</tr>` lines must each be on a single line as shown or you'll get a runtime error. With the block of new code selected, press Tab twice to line up the new code with the existing code.
+> When you paste the code in Visual Studio, line breaks will be changed in a way that breaks the code.  Press Ctrl+Z one time to undo the automatic formatting.  This will fix the line breaks so that they look like what you see here. The indentation doesn't have to be perfect, but the `@</tr><tr>`, `@:<td>`, `@:</td>`, and `@:</tr>` lines must each be on a single line as shown or you'll get a runtime error. With the block of new code selected, press Tab three times to line up the new code with the existing code.


Remove the extra space before "Press Ctrl" and the extra space before "This will fix".

scottaddie · 2017-08-17T01:31:50Z

aspnetcore/data/ef-mvc/inheritance.md

 By [Tom Dykstra](https://github.com/tdykstra) and [Rick Anderson](https://twitter.com/RickAndMSFT)

-The Contoso University sample web application demonstrates how to create ASP.NET Core 1.1 MVC web applications using Entity Framework Core 1.1 and Visual Studio 2017. For information about the tutorial series, see [the first tutorial in the series](intro.md).
+The Contoso University sample web application demonstrates how to create ASP.NET Core MVC web applications using Entity Framework Core and Visual Studio. For information about the tutorial series, see [the first tutorial in the series](intro.md).


Convert to an "xref"-style link.

scottaddie · 2017-08-17T01:32:28Z

aspnetcore/data/ef-mvc/concurrency.md

-* Adds hidden fields for the `DepartmentID` and `RowVersion` properties.
+* Adds a hidden field for the `RowVersion` property.

 Run the Departments Index page. Right click the **Delete** hyperlink for the English department and select **Open in new tab**, then in the first tab click the **Edit** hyperlink for the English department.


Hyphenate "Right click"

Rick-Anderson · 2017-08-17T15:28:39Z

aspnetcore/data/ef-mvc/advanced.md

 ```

-You'll notice something here that might surprise you: the SQL selects up to 2 rows (`TOP(2)`). The `SingleOrDefaultAsync` method doesn't resolve to one row on the server. If the Where clause matches multiple rows, the method must return null, so EF only has to select a maximum of 2 rows, because if 3 or more match the Where clause, the result from the `SingleOrDefault` method is the same as if 2 rows match.
+You'll notice something here that might surprise you: the SQL selects up to 2 rows (`TOP(2)`) from the Person table. The `SingleOrDefaultAsync` method doesn't resolve to one row on the server. If the Where clause matches multiple rows, the method must return null, so EF only has to select a maximum of 2 rows, because if 3 or more match the Where clause, the result from the `SingleOrDefault` method is the same as if 2 rows match.


Spell out the numbers 2 and 3.

That's old school copy/edit. People prefer numbers.

Rick-Anderson · 2017-08-17T15:31:06Z

aspnetcore/data/ef-mvc/concurrency.md

 By [Tom Dykstra](https://github.com/tdykstra) and [Rick Anderson](https://twitter.com/RickAndMSFT)

-The Contoso University sample web application demonstrates how to create ASP.NET Core 1.1 MVC web applications using Entity Framework Core 1.1 and Visual Studio 2017. For information about the tutorial series, see [the first tutorial in the series](intro.md).
+The Contoso University sample web application demonstrates how to create ASP.NET Core MVC web applications using Entity Framework Core and Visual Studio. For information about the tutorial series, see [the first tutorial in the series](intro.md).


Consider making it an include.

Rick-Anderson · 2017-08-17T15:43:53Z

aspnetcore/data/ef-mvc/crud.md

 Run the page by selecting the **Students** tab and clicking **Create New**.

-Enter names and an invalid date and click **Create** to see the error message.
+Enter names and a date. Try entering an invalid date if your browser lets you do that. (Some browsers force you to use a date picker.) Then click **Create** to see the error message.


Consider either having them use another field or mentioning
Chrome and Edge use the date picker. Currently, Firefox and IE do not.

There's no field readily available to do that at this point, so I'm inclined to get this 2.0 version published and leave that for the next edit pass through the tutorials.

Rick-Anderson · 2017-08-17T15:47:23Z

aspnetcore/data/ef-mvc/intro.md

 ## Entity Framework Core NuGet packages

-To add EF Core support to a project, install the database provider that you want to target. For this tutorial, install the SQL Server provider:  [Microsoft.EntityFrameworkCore.SqlServer](https://www.nuget.org/packages/Microsoft.EntityFrameworkCore.SqlServer/). 
+To add EF Core support to a project, install the database provider that you want to target. This tutorial uses SQL Server, and the provider package is [Microsoft.EntityFrameworkCore.SqlServer](https://www.nuget.org/packages/Microsoft.EntityFrameworkCore.SqlServer/). This package is already included in the [Microsoft.AspNetCore.All](xref:fundamentalthe [Microsoft.AspNetCore.All](xref:fundamentals/metapackage) metapackage, so you don't have to install it.


~~already~~

Rick-Anderson · 2017-08-17T15:49:12Z

aspnetcore/data/ef-mvc/intro.md

-Install-Package Microsoft.EntityFrameworkCore.SqlServer
-```
-
 This package and its dependencies (`Microsoft.EntityFrameworkCore` and `Microsoft.EntityFrameworkCore.Relational`) provide run-time support for EF. You'll add a tooling package later, in the [Migrations](migrations.md) tutorial. 


@scottaddie We generally don't update links to xref in exiting tutorials, especially when it's a series like this (all links in the same folder). Even if we move the series, the relative links still work.

Rick-Anderson · 2017-08-17T15:57:16Z

aspnetcore/data/ef-mvc/intro.md

+[!code-csharp[Main](intro/samples/cu/Program.cs?name=snippet_Usings)]

-Now the first time you run the application the database will be created and seeded with test data. Whenever you change your data model, you can delete the database, update your seed method, and start afresh with a new database the same way. In later tutorials you'll see how to modify the database when the data model changes, without deleting and re-creating it.
+Now the first time you run the application, the database will be created and seeded with test data. Whenever you change your data model, you can delete the database, update your seed method, and start afresh with a new database the same way. In later tutorials you'll see how to modify the database when the data model changes, without deleting and re-creating it.


When the data model changes, delete the db, update the seed method. When the app starts new data is seeded.

On this section in the MVC tutorial I have lots of questions on why the seed method isn't running. It's almost always because they're running non-debug and the IIS Express is still running. You need to exit IIS Express to force startup to run again. Do you ever get that question?

Rick-Anderson · 2017-08-17T15:58:21Z

aspnetcore/data/ef-mvc/intro.md

-Now the first time you run the application the database will be created and seeded with test data. Whenever you change your data model, you can delete the database, update your seed method, and start afresh with a new database the same way. In later tutorials you'll see how to modify the database when the data model changes, without deleting and re-creating it.
+Now the first time you run the application, the database will be created and seeded with test data. Whenever you change your data model, you can delete the database, update your seed method, and start afresh with a new database the same way. In later tutorials you'll see how to modify the database when the data model changes, without deleting and re-creating it.
+
+**Note:** For earlier versions of ASP.NET Core, we recommended that you call `DbInitializer.Initialize` in the `Configure` method in *Startup.cs*. In ASP.NET 2.0 we recommend that you use the `Configure` method only to set up the request pipeline. Application startup code, such as `DbInitializer.Initialize`, belongs in the `Main` method. 


Consider removing the entire note. Do we really need to tell them what we did in the past?

tdykstra · 2017-08-17T16:15:48Z

You need to exit IIS Express to force startup to run again. Do you ever get that question?

I haven't seen that myself and haven't seen any questions about it.

tdykstra · 2017-08-17T18:06:52Z

@scottaddie OK to merge?

scottaddie · 2017-08-17T18:30:26Z

tdykstra added 12 commits August 14, 2017 15:17

initial

0edd374

initial2

288b4f1

initial3

58bf06d

initial4

06ef2ac

fix snippet links

7c88bb7

fix highlight

9fe91d9

tut1-3

b1794ac

tut7

4536bd2

tut7b

dd5a0e8

tut8

6514551

tut10

7958ca3

update non-snippet sample

23e96dd

tdykstra requested review from Rick-Anderson and scottaddie August 16, 2017 20:58

dnfclas added the cla-already-signed label Aug 16, 2017

scottaddie requested changes Aug 17, 2017

View reviewed changes

scottaddie feedback

ae26995

Rick-Anderson approved these changes Aug 17, 2017

View reviewed changes

ra feedback

a5b53c4

scottaddie approved these changes Aug 17, 2017

View reviewed changes

tdykstra merged commit 40beeaa into master Aug 17, 2017

tdykstra deleted the td-efmvc branch August 17, 2017 18:36


		### Update the Instructor Edit view

		In Views/Instructors/Edit.cshtml, add a new field for editing the office location, at the end before the Save button :

EF MVC for 2.0 #4000

EF MVC for 2.0 #4000

Uh oh!

Conversation

tdykstra commented Aug 16, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tdykstra commented Aug 17, 2017

Uh oh!

tdykstra commented Aug 17, 2017

Uh oh!

scottaddie commented Aug 17, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tdykstra commented Aug 16, 2017 •

edited

Loading