Skip to content

Conversation

@filzrev
Copy link
Contributor

@filzrev filzrev commented Dec 24, 2025

This PR intended to fix a part issue #2815

By enabling #nullable enable for disassembler/diagnoser related code. and fix nullable errors.

Other Changes

1. DiagnoserActionParameters.cs

  • Add ProcessId getter property.

2. Arm64InstructionFormatter.cs

  • Add code to handle null Instruction.

3. ClrMdArgs.cs

  • Remove nullable from constructor's resultsPath argument.
  • Add code to handle null Json.

4. DataContracts.cs

  • Remove unused TargetFrameworkMoniker property from State.

5. MonoDisassembler.cs

  • Remove nullable from input argument of Parse method.
  • Remove nullable from mono argument of Disassemble method.

Copy link
Collaborator

@timcassell timcassell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@timcassell timcassell merged commit c106b65 into dotnet:master Dec 24, 2025
11 checks passed
@timcassell timcassell added this to the v0.16.0 milestone Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants