-
Notifications
You must be signed in to change notification settings - Fork 386
Fixed tests and included pending unmerged feature PRs #480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed tests and included pending unmerged feature PRs #480
Conversation
@dgvives - More than happy to take some of these changes. Would you be willing to submit separate PR's for more of the systemic changes. Ex: Conversion from It makes it easier to get these out of the way and then we can review just the real changes. |
Reply to #480 (comment) by @jterry75 Agreed, I'll leave out the non functional changes. On next submission should be almost ready for revision |
specgen README formatting
…esAsync System.ArgumentException : Stream was not readable.
Hey dont fully understand the godeps removal set of changes. Do you want to explain that so I can understand the model changes you made as well? |
Reply to #480 (comment) by @jterry75 Changes in godeps come from #472
This retrieves model references for the specified tag from github to local go path, so it is no longer required to include all vendor files within the repository. After applying these changes I updated models:
Because some models don't have rest tags, like All the generated models come from specgen.go and modeldefs.go files Just noticed go.mod file wasn't committed, I'm including it now. |
@dgvives it would have been nice to merge my and a number of other people's changes into your branch rather than copy the changes so that the commit log has a record of who wrote what code. It makes it really hard to review a humongous PR on its own. |
@dgvives - I'm sorry for the additional ask here. Can you please submit a "formatting" PR separate from this one that cleans up all tabs to spaces, removes trailing spaces, fixes comment alignment etc. Second, updating the model should be done in a separate PR so that its easy to review "generated" changes since they are really a stamp of approval and dont need a lot of thought. That will remove 90% of the changes from this PR as well. Then we can review the actual important changes here. I appreciate the work its just really hard to manage this many changes all at once |
ContainerEventParameters
to more genericEventParameters
Included contribs: