Skip to content

Fix BitBucket handling of publicReleaseRefSpec#936

Merged
AArnott merged 1 commit into
v3.6from
fix935
May 10, 2023
Merged

Fix BitBucket handling of publicReleaseRefSpec#936
AArnott merged 1 commit into
v3.6from
fix935

Conversation

@AArnott

@AArnott AArnott commented May 10, 2023

Copy link
Copy Markdown
Collaborator

BitBucket environment variables do not include the refs/ prefix, so we need to add them ourselves (as we do for some other cloud build services already).

Fixes #935

@AArnott AArnott changed the title Fix935 Fix BitBucket handling of publicReleaseRefSpec May 10, 2023
@AArnott AArnott added this to the v3.6 milestone May 10, 2023
BitBucket environment variables do not include the `refs/` prefix, so we need to add them ourselves (as we do for some other cloud build services already).

Fixes #935
@AArnott AArnott changed the base branch from main to v3.6 May 10, 2023 14:26
@AArnott

AArnott commented May 10, 2023

Copy link
Copy Markdown
Collaborator Author

@henriq would you be willing to test this out? I could push the PR build to our CI feed so you could consume it via nuget package.

@henriq

henriq commented May 10, 2023

Copy link
Copy Markdown

@AArnott Sure!

@AArnott

AArnott commented May 10, 2023

Copy link
Copy Markdown
Collaborator Author

Thanks. It's ready for your testing at https://dev.azure.com/andrewarnott/OSS/_artifacts/feed/PublicCI/NuGet/Nerdbank.GitVersioning/overview/3.6.130-gb8bbcd03d8 (and the nbgv equivalent package).
I'll merge this PR after you confirm it works, @henriq.

@henriq

henriq commented May 10, 2023

Copy link
Copy Markdown

LGTM! I've tested this for both branches and tags and get the expected behavior.

Branch

"BuildingRef": "refs/heads/release/test/v1.0"

Tag

"BuildingRef": "refs/tags/2.0"

@AArnott

AArnott commented May 10, 2023

Copy link
Copy Markdown
Collaborator Author

Great. Thank you.

@AArnott AArnott merged commit 42295ab into v3.6 May 10, 2023
@AArnott AArnott deleted the fix935 branch May 10, 2023 15:25
@AArnott

AArnott commented May 11, 2023

Copy link
Copy Markdown
Collaborator Author

@henriq this is now available as https://github.com/dotnet/Nerdbank.GitVersioning/releases/tag/v3.6.132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BuildingRef is incorrectly populated on Bitbucket pipelines

2 participants