Use UTF-8 for OpenAL string marshalling #2439
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marshal.PtrToStringAnsi
uses the system codepage which is problematic especially on windows. OpenAL returns UTF-8 strings which should be parsed as UTF-8.Using the following test code:
with a non-utf-8 codepage and a device named
test ドットネット
, I get:before:
OpenAL Soft on test ãƒ%ッãƒ^ãƒ?ッãƒ^ (Realtek High Definition Audio)
after (with proper console encoding configured):
OpenAL Soft on test ドットネット (Realtek High Definition Audio)