Skip to content

Feature | Introducing Azure Key Vault Provider for Always Encrypted (Add-On) #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Oct 18, 2019
Merged

Feature | Introducing Azure Key Vault Provider for Always Encrypted (Add-On) #273

merged 33 commits into from
Oct 18, 2019

Conversation

cheenamalhotra
Copy link
Member

Addresses #111

Introducing Azure Key Vault provider for Always Encrypted, supported on

  • .NET Framework 4.6+
  • .NET Core 2.1+

David-Engel and others added 30 commits September 13, 2019 16:52
@David-Engel
Initial AKV provider add-on
0c75a1d
@cheenamalhotra
Initial draft for AKV Provider build support
75db54f 
Supports running build-addons.cmd to generate addon packages
@cheenamalhotra
Merge branch 'master' into AKV
fa7cf8b
@cheenamalhotra
Merge branch 'master' into AKV
4f119cd
@cheenamalhotra
Merge branch 'master' into AKV
c030167
@cheenamalhotra
Merge branch 'master' into AKV
2fc6c53
@cheenamalhotra
Merge branch 'master' into AKV
534309c
@cheenamalhotra
Add AKV Tests + Improvements in AKV Provider
ffd4292
@cheenamalhotra
Add Exception tests for AKV
014865d
@cheenamalhotra
More Improvements:
90c1adb 
- Fix warnings when building nuspec
- Move restore method to SqlSetupStrategy
@cheenamalhotra
Merge master to AKV branch
cfa4c5d
@David-Engel
Fixing AKV test and automatically populating AKV key with our own cer…
d0d305a 
…tificate.
@David-Engel
Merge branch 'AKV' of https://github.com/cheenamalhotra/SqlClient int…
0680094 
…o AKV
@cheenamalhotra
Minor changes
358b283
@David-Engel
Merge branch 'AKV' of https://github.com/cheenamalhotra/SqlClient int…
0fd9dcf 
…o AKV
@David-Engel
Did not mean to remove UserKeySet
4d80301
@cheenamalhotra
Merge pull request #1 from David-Engel/AKV
ad0d3a1 
AKV Test fix
@cheenamalhotra
Do not build referenced projects to avoid test issues.
6990cc3
@cheenamalhotra
More enhancements + handy scripts
4ee6975
@cheenamalhotra
Update Buildguide for new env variables
11fcf6c
@cheenamalhotra
Updates
c6b8d47
@cheenamalhotra
More Improvements
1e07c94
@cheenamalhotra
Update build scripts
0759eaa
@cheenamalhotra
Attempt to fix compilation issues on Unix
31c13b8
@cheenamalhotra
More improvements
21a77af
@cheenamalhotra
Rename internal variable IsEnabledNetFx to IsEnabledWindows
56401f1
@cheenamalhotra
Build AKV provider for Platform tests
9a000ef
@David-Engel
Moving the AKV cert code into CertificateUtility and other minor chan…
678b499 
…ges.
@David-Engel
Merge branch 'AKV' of https://github.com/dotnet/SqlClient into AKV
c7b55d4
@David-Engel
Fix to account for unset env variable
75c9dee
David-Engel
David-Engel approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@David-Engel David-Engel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to circle back later and re-work the changes to tests using SQLSetupStrategy. But other than that, it looks good.

@cheenamalhotra cheenamalhotra merged commit e26d634 into master Oct 18, 2019
@cheenamalhotra cheenamalhotra deleted the AKV branch October 18, 2019 18:00
yukiwongky pushed a commit to yukiwongky/SqlClient that referenced this pull request Nov 5, 2019
@cheenamalhotra
Feature | Introducing Azure Key Vault Provider for Always Encrypted (…
f1c3b03 
…Add-On) (dotnet#273)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@David-Engel David-Engel David-Engel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cheenamalhotra @David-Engel