Cleanup | Remove More Dead SMI Code (Part 2)#3414

Merged

benrr101 merged 18 commits intomainfrom

dev/russellben/cleanup/smi-dead-code2

Jun 18, 2025

Commits on Jun 11, 2025

Oh hey, InOutOfProcHelper.InProc always returns false! Let's propagate that false everywhere it was being used to determine what other branches of code can be deleted
benrr101
committed
Remove usages of IsInProc that were always false
benrr101
committed
Remove dead code in SmiContextFactory and distill properties down to exceptions they will always throw b/c _smiLink will always be null
benrr101
committed
Propagate always thrown exceptions, remove that code from SmiContextFactory
benrr101
committed
Remove SmiVersion that was hardcoded to 2008. Propagate 2008 to all usages of the property
benrr101
committed
Remove SmiContextFactory.LatestVersion by replacing usage with 2008 and propagate that forward, allowing us to remove MetadataUtilsSmi.IsValidForSmiVersion and a block of code in SqlDataRecord
benrr101
committed
Propagate 2008 version, which eliminates a bunch of conditions, eliminating the last uses of SmiVersion2008
benrr101
committed
Delete the now unused SmiContextFactory class
benrr101
committed
Remove _smiRequestContext from SqlCommand since it is always assigned `null`, replacing usages of it with `null`
benrr101
committed
Remove context parameter from ValueUtilsSmi.GetOutputParameterV3Smi, since it is always passed to itself
benrr101
committed
Remove context parameter from ValueUtilsSmi.GetOutputParameterV200Smi, since it is always passed to itself and is always null
benrr101
committed
Delete ExecuteToPipe since it is no longer being used.
benrr101
committed
Remove _recordContext from SqlDataRecord since it is always null, propagate null to all usages of it
benrr101
committed
SqlInternalConnectionSmi.InternalContext is always null, deleting and propagating null to all usages of it
benrr101
committed
Removing SqlContext usages from ValueUtilsSmi - it was always null, so it can be eliminated
benrr101
committed
Removing last references to SqlContext in SqlInternalConnectionSmi
benrr101
committed
Delete SmiContext
benrr101
committed

Commits on Jun 12, 2025

@edwardneal is a hero, deleting another bundle of unused code.
benrr101
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Cleanup | Remove More Dead SMI Code (Part 2)#3414

Cleanup | Remove More Dead SMI Code (Part 2)#3414
benrr101 merged 18 commits intomainfrom
dev/russellben/cleanup/smi-dead-code2

Commits on Jun 11, 2025

Oh hey, InOutOfProcHelper.InProc always returns false! Let's propagate that false everywhere it was being used to determine what other branches of code can be deleted

Remove usages of IsInProc that were always false

Remove dead code in SmiContextFactory and distill properties down to exceptions they will always throw b/c _smiLink will always be null

Propagate always thrown exceptions, remove that code from SmiContextFactory

Remove SmiVersion that was hardcoded to 2008. Propagate 2008 to all usages of the property

Remove SmiContextFactory.LatestVersion by replacing usage with 2008 and propagate that forward, allowing us to remove MetadataUtilsSmi.IsValidForSmiVersion and a block of code in SqlDataRecord

Propagate 2008 version, which eliminates a bunch of conditions, eliminating the last uses of SmiVersion2008

Delete the now unused SmiContextFactory class

Remove _smiRequestContext from SqlCommand since it is always assigned `null`, replacing usages of it with `null`

Remove context parameter from ValueUtilsSmi.GetOutputParameterV3Smi, since it is always passed to itself

Remove context parameter from ValueUtilsSmi.GetOutputParameterV200Smi, since it is always passed to itself and is always null

Delete ExecuteToPipe since it is no longer being used.

Remove _recordContext from SqlDataRecord since it is always null, propagate null to all usages of it

SqlInternalConnectionSmi.InternalContext is always null, deleting and propagating null to all usages of it

Removing SqlContext usages from ValueUtilsSmi - it was always null, so it can be eliminated

Removing last references to SqlContext in SqlInternalConnectionSmi

Delete SmiContext

Commits on Jun 12, 2025

@edwardneal is a hero, deleting another bundle of unused code.