com.google.android.material-1.1.0-rc1 error on build

[ibryskin]

Need to add these lines to com.google.android.material/material/transforms/Metadata.xml for 1.1.0-rc1:

<remove-node path="/api/package[@name='com.google.android.material.button']/interface[@name='MaterialButton.OnPressedChangeListener']" />
<remove-node path="/api/package[@name='com.google.android.material.datepicker']/interface[@name='MaterialCalendar.OnDayClickListener']" />
<remove-node path="/api/package[@name='com.google.android.material.bottomappbar']/interface[@name='BottomAppBar.AnimationListener']" />

[moljac]

@ibryskin
Do you have minimal repro sample for this issue, please?

I will add those for now, but I don't like removing nodes, so sample would help me checking the root cause of the issue.

[ibryskin]

Here's a sample. Building this project failed with these errors (with 1.1.0-rc1):

JAVAC0000:  error: AnimationListener is not public in BottomAppBar; cannot be accessed from outside package
JAVAC0000:  error: OnPressedChangeListener is not public in MaterialButton; cannot be accessed from outside package
JAVAC0000:  error: OnDayClickListener is not public in MaterialCalendar; cannot be accessed from outside package

Test56.zip

[moljac]

@ibryskin
Thanks for the repro sample.

Seems like I'll have to tweak accessibility (public) for those interfaces. Not sure yet.

The reason I'm reluctant to remove-node is that in the future with C# 8 will have default method implementations in the interfaces. Removing node is for me last option, but I do that too when I'm forced to.

[Codelisk]

Workaround for that in the meantime?

[moljac]

@hudait
Build it yourself or wait DevOps builds to be finished (matter of hours)

[moljac]

@ibryskin

Did rc2 resolve this issue? Please provide some feedback

[moljac]

My local tests show that rc2 solved this problem

[ibryskin]

I confirm that problem is solved. rc2 is building and working fine. Thank you.

[moljac]

OK. Closing this one!